Closed Bug 556269 Opened 11 years ago Closed 11 years ago

Port |Bug 514787 - Remove unused TARGET_CARBON and TARGET_API_MAC_CARBON in configure.in| to comm-central

Categories

(MailNews Core :: Build Config, defect)

All
macOS
defect
Not set
minor

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 3.1b2

People

(Reporter: sgautherie, Assigned: sgautherie)

References

Details

Attachments

(1 file, 1 obsolete file)

No description provided.
Flags: in-testsuite-
Blocks: C192ConfSync
Blocks: 555684
Bug 514787 patch Bv1-CC, with a s/TARGET_CARBON/MOZ_WIDGET_COCOA/.
Not as explicit, but should be fine as we have bug 555684 as a follow-up.

Passed on Try.
Attachment #436190 - Flags: superreview?(bugzilla)
Attachment #436190 - Flags: review?(bugzilla)
Attachment #436190 - Flags: superreview?(bugzilla)
Attachment #436190 - Flags: superreview-
Attachment #436190 - Flags: review?(bugzilla)
Attachment #436190 - Flags: review-
Comment on attachment 436190 [details] [diff] [review]
(Av1) Just copy it, With a couple nsMsgAppleEncode.cpp #ifdef rewrites

>+#ifdef XP_MACOSX
>+
> #include "nscore.h"
> #include "msgCore.h"
> #include "nsMimeTypes.h"
> #include "prprf.h"
> #include "nsServiceManagerUtils.h"
> #include "nsMsgAppleDouble.h"
> #include "nsMsgAppleCodes.h"
> 
>-#ifdef XP_MACOSX
>-

If you ever have to ifdef a whole file, then you're doing something wrong. The file is already only built if cocoa is the widget, so this ifdef can just be dropped.

>-#if TARGET_CARBON
>+#if MOZ_WIDGET_COCOA
>+    // Carbon doesn't support GetWDInfo(). (Bug 555684)

Given what we've previously said about the file being only built if we've got cocoa, just turn this into #if 1
Av1, with comment 2 suggestion(s).
Attachment #436190 - Attachment is obsolete: true
Attachment #438311 - Flags: superreview?(bugzilla)
Attachment #438311 - Flags: review?(bugzilla)
Attachment #438311 - Flags: superreview?(bugzilla)
Attachment #438311 - Flags: superreview+
Attachment #438311 - Flags: review?(bugzilla)
Attachment #438311 - Flags: review+
Comment on attachment 438311 [details] [diff] [review]
(Av2) Just copy it, With a couple nsMsgApple*Encode.cpp #ifdef rewrites, (m-1.9.2+)
[Checkin: Comment 4]


http://hg.mozilla.org/comm-central/rev/ac35d3b6584e
Attachment #438311 - Attachment description: (Av2) Just copy it, With a couple nsMsgApple*Encode.cpp #ifdef rewrites → (Av2) Just copy it, With a couple nsMsgApple*Encode.cpp #ifdef rewrites, (m-1.9.2+) [Checkin: Comment 4]
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 3.1b2
You need to log in before you can comment on or make changes to this bug.