556311 - Explanatory animation not visible at about:firstrun, requires scrolling it in view

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Jan D]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; de; rv:1.9.2.2) Gecko/20100316 Firefox/3.6.2
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv: 1.9.2.3pre) / Fennec 1.1a2pre

The explanatory animation showing how to reveal the chrome is not in view since it appeares below the visible content. Therefore scrolling is required - but this is not discoverable too in some display ratios. (since the clip is not partly, but totally hidden)

Reproducible: Always

Steps to Reproduce:
1.open about:firstrun
2.click "take a Tour!"
3.You are likely not to see the clip
(4. Scroll down to see the clip)
Actual Results:  
I did not see the clip demonstrating how to reveal the chrome until I scrolled it in view.

Expected Results:  
The demonstration should be shown in a <div>-"window" (which can be closed) on top of the other page content or fennec should scroll the clip in view automatically.

Comment 1

[Matt Brubeck (:mbrubeck)]

Attachment: patch

Here's a one line patch to scroll the animation into view.

Tested only on desktop so far - I'm not sure if there might be timing issues if the image takes longer to load on the handset.

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

pushed:
http://hg.mozilla.org/mobile-browser/rev/7a1e2eb6ca2c

Comment 3

[Aakash Desai [:aakashd]]

verified FIXED On builds:
Mozilla/5.0 (X11; U; Linux armv7l; Nokia N900; en-US; rv:1.9.2.4pre) Gecko/20100407 Namoroka/3.6.4pre Fennec/1.1a2pre

and

Mozilla/5.0 (X11; U; Linux armv6l; en-US; rv:1.9.3a4pre) Gecko/20100407 Namoroka/3.7a4pre Fennec/1.1a2pre