556315 - Followup patches for bug 515496

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Jason Orendorff [:jorendorff]]

I landed bug 515496 (blazinglyfastthis). This bug is to spin out the changes I suggested in my review.

Comment 1

[Jason Orendorff [:jorendorff]]

Attachment: Part 1, remove GCReachableFrame - v1

Comment 2

[Jason Orendorff [:jorendorff]]

Attachment: Part 2, JSObject::getGlobal() and JSStackFrame::getThisObject() - v1

Comment 3

[Andreas Gal :gal]

Comment on attachment 436222 [details] [diff] [review]
Part 2, JSObject::getGlobal() and JSStackFrame::getThisObject() - v1

Might be worth to make getGlobal() inline (jsobjinlines.h).

Comment 4

[Brendan Eich [:brendan]]

(In reply to comment #3)
> (From update of attachment 436222 [details] [diff] [review])
> Might be worth to make getGlobal() inline (jsobjinlines.h).

Could be -- small code size increase for perf win. size and shark or *grind could be enough to tell.

/be

Comment 5

[Jason Orendorff [:jorendorff]]

Inlining getGlobal didn't affect perf. It's not called frequently.

Bizarrely, inlining it increases the final code size of libmozjs.so by 3 bytes. I don't even want to know.

Comment 6

[Jason Orendorff [:jorendorff]]

Part 1: http://hg.mozilla.org/tracemonkey/rev/62016a11cd1c
Part 2: http://hg.mozilla.org/tracemonkey/rev/3f92bb022ee9

Comment 7

[Robert Sayre]

http://hg.mozilla.org/mozilla-central/rev/62016a11cd1c

Comment 8

[Robert Sayre]

http://hg.mozilla.org/mozilla-central/rev/3f92bb022ee9