Closed Bug 556323 Opened 15 years ago Closed 15 years ago

secmod_handleReload uses uninitialized locals

Categories

(NSS :: Libraries, defect, P2)

3.12.4
defect

Tracking

(Not tracked)

RESOLVED FIXED
3.12.7

People

(Reporter: timeless, Assigned: nelson)

References

()

Details

(Keywords: coverity)

Attachments

(1 file)

135 secmod_handleReload(SECMODModule *oldModule, SECMODModule *newModule) 142 SECStatus rv; 173 slot = SECMOD_OpenNewSlot(oldModule, newModuleSpec); 174 if (slot) { 212 } 213 214 loser: 220 return rv;
more critically, it uses an unintialized conflist if !oldModule->internal 135 secmod_handleReload(SECMODModule *oldModule, SECMODModule *newModule) 143 SECMODConfigList *conflist; 162 if (oldModule->internal) { 165 } 169 if (conflist && secmod_MatchConfigList(newModuleSpec, conflist, count)) {
Summary: secmod_handleReload returns rv uninitialized if SECMOD_OpenNewSlot fails → secmod_handleReload uses uninitialized locals
Assignee: nobody → rrelyea
Severity: minor → normal
Priority: -- → P2
Assignee: rrelyea → nelson
Target Milestone: --- → 3.12.7
Version: trunk → 3.12.4
This should fix both concerns.
Attachment #441327 - Flags: review?(rrelyea)
Comment on attachment 441327 [details] [diff] [review] Patch v1 for NSS Trunk r+ rrelyea
Attachment #441327 - Flags: review?(rrelyea) → review+
Checking in pk11wrap/pk11load.c; new revision: 1.30; previous revision: 1.29
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: