secmod_handleReload uses uninitialized locals

RESOLVED FIXED in 3.12.7

Status

P2
normal
RESOLVED FIXED
9 years ago
9 years ago

People

(Reporter: timeless, Assigned: nelson)

Tracking

({coverity})

3.12.4
3.12.7
coverity

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(1 attachment)

(Reporter)

Description

9 years ago
135 secmod_handleReload(SECMODModule *oldModule, SECMODModule *newModule)
142     SECStatus rv;

173     slot = SECMOD_OpenNewSlot(oldModule, newModuleSpec);
174     if (slot) {
212     }
213 
214 loser:
220     return rv;
(Reporter)

Comment 1

9 years ago
more critically, it uses an unintialized conflist if !oldModule->internal

135 secmod_handleReload(SECMODModule *oldModule, SECMODModule *newModule)
143     SECMODConfigList *conflist;

162     if (oldModule->internal) {
165     }

169     if (conflist && secmod_MatchConfigList(newModuleSpec, conflist, count)) {
Summary: secmod_handleReload returns rv uninitialized if SECMOD_OpenNewSlot fails → secmod_handleReload uses uninitialized locals
(Assignee)

Updated

9 years ago
Assignee: nobody → rrelyea
Severity: minor → normal
Priority: -- → P2
(Assignee)

Updated

9 years ago
Assignee: rrelyea → nelson
(Assignee)

Updated

9 years ago
Target Milestone: --- → 3.12.7
Version: trunk → 3.12.4
Created attachment 441327 [details] [diff] [review]
Patch v1 for NSS Trunk

This should fix both concerns.
Attachment #441327 - Flags: review?(rrelyea)

Comment 3

9 years ago
Comment on attachment 441327 [details] [diff] [review]
Patch v1 for NSS Trunk

r+ rrelyea
Attachment #441327 - Flags: review?(rrelyea) → review+
Checking in pk11wrap/pk11load.c; new revision: 1.30; previous revision: 1.29
Status: NEW → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.