Closed Bug 556414 Opened 10 years ago Closed 10 years ago

Panning inside overflow:auto elements (Google Reader) stops for some posts

Categories

(Firefox for Android Graveyard :: Panning/Zooming, defect)

defect
Not set

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: whimboo, Assigned: mbrubeck)

References

()

Details

Attachments

(2 files)

Even with bug 511432 fixed I still have problems on Google Reader reading some of the posts. A good example I have spotted is the feed from David Tenser
(http://djst.org/blog/feed/). Add it to Google Reader and try to read the post
about "Random UX change for the sake of... change?" which extends the normal
space. You will see some cut-off letters at the bottom of the frame. Also you are even not able to pan further down to get to the next postings. All later posts are hidden.
Attached file testcase
I'm not sure this is showing the actual bug with Google Reader, but this is showing at least the scrolling bug with Fennec too.
It seems to me that the target in the patch in bug 511432 also needs to be crawled for parentNodes.
You might as well use the logic used in the patch for bug 295977, since that seems to work well.
tracking-fennec: --- → ?
Attached patch patchSplinter Review
This patch fixes the testcase (attachment 436385 [details]) and matches the logic from bug 295977.  Like Martijn, I have not yet verified that the testcase and the original report are the same bug.

The particular bug in the testcase is that we were always treating "overflow: scroll" elements as scrollable even when they had no overflow.
Assignee: nobody → mbrubeck
Status: NEW → ASSIGNED
Attachment #438203 - Flags: review?(mark.finkle)
Component: Linux/Maemo → Panning/Zooming
OS: Linux → All
QA Contact: maemo-linux → pan-zoom
Hardware: ARM → All
The patch in attachment 436385 [details] fixes both the testcase and the originally reported problem in http://www.google.com/reader/view/#stream/feed%2Fhttp%3A%2F%2Fdjst.org%2Fblog%2Ffeed%2F
(In reply to comment #3)
> The patch in attachment 436385 [details] fixes both the testcase and the originally

Attachment 436385 [details] is the testcase, I guess you mean attachment 438203 [details] [diff] [review].
(In reply to comment #4)
> Attachment 436385 [details] is the testcase, I guess you mean attachment 438203 [details] [diff] [review].

Yes, I do.  Oops.
pushed:
http://hg.mozilla.org/mobile-browser/rev/88653628be66
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Verified fixed, using:
Mozilla/5.0 (X11; U; Linux armv7l; en-US; rv:1.9.2.5pre) Gecko/20100414 Namoroka/3.6.5pre Fennec/1.1a2pre
Status: RESOLVED → VERIFIED
That one works fine now on my Maemo device. Thanks for fixing it.
Comment on attachment 438203 [details] [diff] [review]
patch

My guess is that mark finkle r+-ed this patch, since it was checked in.
Attachment #438203 - Flags: review?(mark.finkle) → review+
tracking-fennec: ? → ---
You need to log in before you can comment on or make changes to this bug.