Closed Bug 556454 Opened 13 years ago Closed 13 years ago

engine.sync should always check engine.enabled

Categories

(Firefox :: Sync, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: mconnor, Assigned: Mardak)

References

Details

Attachments

(1 file)

We can kill getEnabled and just call sync on all registered engines.  One less API call to write tests for!
Flags: blocking-weave1.3+
Whiteboard: [b2]
Whiteboard: [b2]
Target Milestone: 1.3 → 1.3b3
Attached patch v1Splinter Review
Attachment #442525 - Flags: review?(mconnor)
Attachment #442525 - Flags: review?(mconnor) → review+
http://hg.mozilla.org/labs/weave/rev/7f32454212d2
Just check if the engine is enabled at the beginning of sync. For now keep getEnabled as it's used for other behavior and not just sync.
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Blocks: 563989
Component: Firefox Sync: Backend → Sync
Product: Cloud Services → Firefox
You need to log in before you can comment on or make changes to this bug.