engine.sync should always check engine.enabled

RESOLVED FIXED in 1.3b3

Status

Cloud Services
Firefox Sync: Backend
RESOLVED FIXED
8 years ago
8 years ago

People

(Reporter: mconnor, Assigned: Mardak)

Tracking

unspecified
1.3b3
Points:
---
Bug Flags:
blocking-weave1.3 +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

8 years ago
We can kill getEnabled and just call sync on all registered engines.  One less API call to write tests for!
Flags: blocking-weave1.3+
(Reporter)

Updated

8 years ago
Whiteboard: [b2]
(Reporter)

Updated

8 years ago
Whiteboard: [b2]
Target Milestone: 1.3 → 1.3b3
(Assignee)

Comment 1

8 years ago
Created attachment 442525 [details] [diff] [review]
v1
Attachment #442525 - Flags: review?(mconnor)
(Reporter)

Updated

8 years ago
Attachment #442525 - Flags: review?(mconnor) → review+
(Assignee)

Comment 2

8 years ago
http://hg.mozilla.org/labs/weave/rev/7f32454212d2
Just check if the engine is enabled at the beginning of sync. For now keep getEnabled as it's used for other behavior and not just sync.
Status: NEW → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
(Assignee)

Updated

8 years ago
Blocks: 563989
You need to log in before you can comment on or make changes to this bug.