556469 - Personas detail pages 404 when visited from /thunderbird

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Public Pages, defect, P5)

Description

[Stephen Donner [:stephend] Not actively reading bugmail]

STR:

1. Load https://preview.addons.mozilla.org/z/en-US/thunderbird/addon/64762/#reviews
2. Under "Other add-ons by nydile", on the right, click either of the "he-he..." add-ons

Actual Result:

https://preview.addons.mozilla.org/z/en-US/thunderbird/addon/86341/ is a 404

Expected Results:

Should be linking to the *Firefox* app-view of the add-on: https://preview.addons.mozilla.org/z/en-US/firefox/addon/86341/

(This is fine in Remora.)

Comment 1

[Jeff Balogh (:jbalogh)]

Do we need to add an app parameter to reverse (and {% url %}) that lets us force a different app?

Comment 2

[Justin Scott [:fligtar]]

Let's roll this krupa-bug in with the [z] implementation if possible.

Comment 3

[Wil Clouser [:clouserw]]

This is working fine for me on a different author.  Example: https://preview.addons.mozilla.org/z/en-US/thunderbird/addon/10488/


I think this is something QA messed up behind the scenes and it's presenting as broken here.  Can someone confirm it's working on pages that aren't QA's?

Comment 4

[Stephen Donner [:stephend] Not actively reading bugmail]

Wait; we don't know what's causing this, and, just because we can't re-reproduce it, we say it's fixed?  We should investigate; I haven't done anything intentional, to my knowledge, and even if I had, I don't see why or how that should result in a 404.

Comment 5

[Wil Clouser [:clouserw]]

QA has access to the admin sections of the site and, in the past, has changed a bunch of values there for their add-ons.  Sometimes that messes stuff up because the error checking there isn't the best.  If we can't reproduce this on any other add-ons that's what I assume happened.

Comment 6

[Jeff Balogh (:jbalogh)]

(In reply to comment #0)

The real bug here is this:

> https://preview.addons.mozilla.org/z/en-US/thunderbird/addon/86341/ is a 404

I don't care if we have a redirect from thunderbird to firefox, but we should be able to find the application that will display that add-on.

Also, that's a persona, which should be supported by thunderbird.

Comment 7

[Stephen Donner [:stephend] Not actively reading bugmail]

(In reply to comment #5)
> QA has access to the admin sections of the site and, in the past, has changed a
> bunch of values there for their add-ons.  Sometimes that messes stuff up
> because the error checking there isn't the best.  If we can't reproduce this on
> any other add-ons that's what I assume happened.

So you're saying "the error checking there isn't the best" is a bug, but you're happy to mark this Fixed?  Doesn't make sense to me, but what do I know.

Comment 8

[Fred Wenzel [:wenzel]]

Here you go.

http://github.com/jbalogh/zamboni/commit/4a814014406d036f35f8a7fc312883e136b84c7d

Comment 9

[Stephen Donner [:stephend] Not actively reading bugmail]

It's sad-making, but I can still repro.

Comment 10

[Fred Wenzel [:wenzel]]

Really? The URL of this bug:

https://preview.addons.mozilla.org/z/en-US/thunderbird/addon/64762/#reviews

is everything but a 404 for me, though it was before I fixed it.

I'll look into the URL from comment 6 again though, which is an error 500 on both Firefox and Thunderbird. There might be another bug there.

Comment 11

[Fred Wenzel [:wenzel]]

The bug here is fixed, but the remainder from comment 6 is apparently completely unrelated and a dupe of bug 559688 (as the traceback clouserw helped me obtain off preview suggests). Marking this a dependency.

Comment 12

[Stephen Donner [:stephend] Not actively reading bugmail]

I can still reproduce the original bug from comment 0.

Comment 13

[Fred Wenzel [:wenzel]]

(In reply to comment #6)
> (In reply to comment #0)
> 
> The real bug here is this:
> 
> > https://preview.addons.mozilla.org/z/en-US/thunderbird/addon/86341/ is a 404
> 
> I don't care if we have a redirect from thunderbird to firefox, but we should
> be able to find the application that will display that add-on.
> 
> Also, that's a persona, which should be supported by thunderbird.

It's not a persona, it's a search engine. Currently, we serve a 404 if an add-on type is invalid for the current app, but we redirect if the type is valid but the current version does not support this app. From a user point of view that makes limited sense. I'll cook up a patch that'll redirect in either case and only raise a 404 if there's nothing we can do.

Comment 14

[Fred Wenzel [:wenzel]]

(In reply to comment #13)
> I'll cook up a patch that'll redirect in either
> case and only raise a 404 if there's nothing we can do.

I fixed this in http://github.com/jbalogh/zamboni/commit/a5c1687a38e4524011a9862ad4b6b5060f083fed .

Though on preview, it's not available altogether, it seems. Perhaps the DB is out of date?

Comment 15

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED; thanks, Fred (my original bug).