556491 - [autoconfig] guessConfig() only finds first AUTH method for SMTP

Status: RESOLVED FIXED

(Thunderbird :: Account Manager, defect)

Description

[Ben Bucksch (:BenB)]

Reproduction:
1. Start account creation wizard
2. Enter "[e-mail]" as email address, and [Continue]
3. Click on [Manual Setup]
4. in Account Manager, to to Outgoing SMTP servers and check the new server.
   Check which SMTP server and specifically which password authentication is
   used.

Actual result:
Unencrypted password is used

Expected result:
Encrypted password is used

Server:
netcat smtp.fastwebnet.it 25, and entering "EHLO foo" gives:
...
250-AUTH=LOGIN                                                                  
250-AUTH LOGIN CRAM-MD5 DIGEST-MD5 PLAIN
...

Implementation:
From the code, I think that the first AUTH= line is irrelevant.
We used regexp e.g.
"AUTH CRAM-MD5"
so we wouldn't match the first line anyways (to my knowledge "AUTH " is correct, and IMAP used "AUTH=").
However, we wouldn't match the second line either, because it starts with "AUTH LOGIN". IMAP repeats the "AUTH" and uses "AUTH=LOGIN AUTH=CRAM-MD5", but not so SMTP. So, we need to relax the regexp.

Comment 1

[Ben Bucksch (:BenB)]

Attachment: Fix, v1

This fixes the problem.

From what I understand, this problem existed in 3.0, too.
Please give this bug precedence in review, as it's needlessly using an insecure setup.

Comment 2

[Blake Winton (:bwinton) (:☕️)]

Comment on attachment 436451 [details] [diff] [review]
Fix, v1

Yeah, it could be better, but that's a followup bug.

r=me.

Comment 3

[Ben Bucksch (:BenB)]

Commited as <http://hg.mozilla.org/comm-central/rev/0d37fec98367>.

FIXED

I will file a followup bug for making the regexps match more precisely (less wildly), or feel free to file it.

Comment 4

[Blake Winton (:bwinton) (:☕️)]

Followup bug filed as Bug 556531.

Comment 5

[Mark Banner (:standard8)]

Comment on attachment 436451 [details] [diff] [review]
Fix, v1

This looks like a good fix to get into 3.0.5. a=Standard8.

Comment 6

[Ben Bucksch (:BenB)]

Attachment: Fix, 3.0 branch

The code changed in 3.1, so this is the corresponding 3.0 version of the patch.

Comment 7

[Ben Bucksch (:BenB)]

Commited to 3.0 <http://hg.mozilla.org/releases/comm-1.9.1/rev/d923bd468843>