556601 - start page polish

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Madhava Enros [:madhava]]

Two things:

1. When there's only one "tab from last time" we shouldn't show the "Open all in tabs" line
http://www.flickr.com/photos/madhava_work/4481970245/in/photostream/

2. "About Mozilla" text is too small
http://www.flickr.com/photos/madhava_work/4482144080/

we should bring it up to the same size as the title text (i.e. "Add-ons for your firefox"); maybe use a 32px icon, too?

Comment 1

[Madhava Enros [:madhava]]

Oh, a third thing:

3. We should provide some feedback that you've tapped on the items that make up the page, like a blue background highlighting.

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

Stuart mentioned wanting to see other content is the tabs list is empty as well.

Comment 4

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: patch

This patch:
* Bumps up the "About Mozilla" font size to 18px (same as titles)
* Hides "Open all in tabs" if only 1 tab is listed
* Adds blue highlighting to the elements when clicked. This is done using "tabindex=-1" and a tweak to our canvas highlighter code. This may not make the entire row highlighted. It depends on the element clicked. It could just highlight the title or version, for example.

(other simple approaches to highlighting are welcome)

Comment 5

[Lars Gunther]

When switching to portrait mode, the start page should resize as well so we do not need to scroll sideways. Should that be a separate bug?

(BTW, the new start page is great. Kudos!)

Comment 6

[Lars Gunther]

Never mind. I found bug 556601.
	
Sorry about the noise.

Comment 7

[Aakash Desai [:aakashd]]

Hi Lars, actually the bug your'e trying to find is here: https://bugzilla.mozilla.org/show_bug.cgi?id=556618

Thanks for using our nightly builds and thank you again for notifying us! We appreciate you taking the time out of your day to do come here.

Comment 8

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: Patch

(In reply to comment #4)
> Created an attachment (id=436779) [details]
> patch
> 
> This patch:
> * Bumps up the "About Mozilla" font size to 18px (same as titles)
> * Hides "Open all in tabs" if only 1 tab is listed
> * Adds blue highlighting to the elements when clicked. This is done using
> "tabindex=-1" and a tweak to our canvas highlighter code. This may not make the
> entire row highlighted. It depends on the element clicked. It could just
> highlight the title or version, for example.
> 
> (other simple approaches to highlighting are welcome)

This patch is based on Mark's patch, except that I've removed the tabindex=-1 addition to replace it by *[role=button] because we already handle that into the FormHelper code so I think it make sense.
The code highlight the entire row instead of only one part of it by using the pointer-events: none property in css.

Comment 9

[Madhava Enros [:madhava]]

Attachment: 42x32px dino head

Comment 10

[Madhava Enros [:madhava]]

Attachment: 32x24px dino head

Comment 11

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 436879 [details] [diff] [review]
Patch

switchng to role="button" is a good idea. pointer-events is what I was looking for! Makes life easier.

I added a mozilla logo and a throbber row in add-ons while loading.

Comment 12

[Mark Finkle (:mfinkle) (use needinfo?)]

pushed:
http://hg.mozilla.org/mobile-browser/rev/306b3b484706

Comment 13

[Aakash Desai [:aakashd]]

verified FIXED for the problems outlined in comment #0 and #1 on builds:

Mozilla/5.0 (X11; U; Linux armv7l; Nokia N900; en-US; rv:1.9.2.4pre) Gecko/20100406 Namoroka/3.6.4pre Fennec/1.1a2pre

and

Mozilla/5.0 (X11; U; Linux armv6l; en-US; rv:1.9.3a4pre) Gecko/20100406 Namoroka/3.7a4pre Fennec/1.1a2pre