556617 - volume rocker zooming allows zooming out past page-width

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Madhava Enros [:madhava]]

By zooming out with the volume rocker, I can zoom out until the web page is taking up less than the available space.  This leaves an awkward "nothing" area next to the vertical band of webcontent. I think zooming out should stop at 100%.

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

I think you mean "page-width", not 100% zoom

Comment 2

[Matt Brubeck (:mbrubeck)]

For comparison, Android 2.0 and iPhone do not allow zooming out past page-width.

On the other hand, zooming out further is useful for panning quickly through very long pages (especially since there's no draggable scrollbar or other quick-scroll UI in Fennec).

Comment 3

[Matt Brubeck (:mbrubeck)]

Attachment: patch

This patch restricts the zoomin/zoomout commands to zoom levels greater than the "page-width" level.

For this we want the exact unadjusted "to fit" zoom level - not the "default" level from getZoomForPage() which might be adjusted by content metadata or our own heuristics.  So I split getZoomForPage into two functions, one of which just returns the fit-width zoom level.

BrowserView.zoomToPage is dead code since changeset 490d48e0c295 (bug 530887), so I deleted it rather than update it.  I also fixed some obsolete references to it in comments.

Comment 4

[Lars Gunther]

I like this feature. But I would prefer to have the page centered... Perhaps do some usability testing or get some other feedback before it is considered a bug?

Comment 5

[Matt Brubeck (:mbrubeck)]

(In reply to comment #4)
> I like this feature. But I would prefer to have the page centered... Perhaps do
> some usability testing or get some other feedback before it is considered a
> bug?

I agree - I think we should try out this patch, but consider whether it's a net gain or not.

Comment 6

[Mark Finkle (:mfinkle) (use needinfo?)]

pushed:
http://hg.mozilla.org/mobile-browser/rev/1e1e97caa616

Comment 7

[Aakash Desai [:aakashd]]

verified FIXED on builds:

Mozilla/5.0 (X11; U; Linux armv7l; Nokia N900; en-US; rv:1.9.2.4pre) Gecko/20100412 Namoroka/3.6.4pre Fennec/1.1a2pre

and

Mozilla/5.0 (X11; U; Linux armv6l; en-US; rv:1.9.3a4pre) Gecko/20100412 Namoroka/3.7a4pre Fennec/1.1a2pre

We should update one of the screen navigation testcases to regression test this bug.

Comment 8

[Aakash Desai [:aakashd]]

test case https://litmus.mozilla.org/show_test.cgi?id=7522 updated to regression test this bug