556654 - Don't show any context menu if the webpage cancels "contextmenu"

Status: RESOLVED INVALID

(Firefox for Android Graveyard :: General, defect)

Description

[Aakash Desai [:aakashd]]

Build Id:
Mozilla/5.0 (X11; U; Linux armv7l; Nokia N900; en-US; rv:1.9.2.3pre) Gecko/20100401 Namoroka/3.6.3pre Fennec/1.1a2pre

Steps to Reproduce:
1. Go to maps.google.com
2. Tap and hold down on the map

Actual Results:
The context menu comes up with the save image option

Expected Results:
Since it's not an image, the save image option (and ultimately the context menu) shouldn't pop-up.

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

It _is_ an image, so the code is working as designed. You could say that since Google Maps tries to override the context menu (as it does on desktop) we should not show our context menu - but that is a different bug.

Comment 2

[Aakash Desai [:aakashd]]

Well, that's kinda where I was going with this. Can't we just use this bug and mention that it should match the behavior on desktop firefox?

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

I don't think we should show the webpage's context menu. But we could look into just displaying no context menu at all (even our own).

I don't see this as blocking though

Comment 4

[Mark Finkle (:mfinkle) (use needinfo?)]

Madhava - Do we want the webpage to be able to cancel our contextmenu? With so much functionality, especially "sharing" - I say no.

Comment 5

[Mark Finkle (:mfinkle) (use needinfo?)]

We are not doing this for 2.0. Our context menus take priority for now