556656 - Blank form helper pops-up for un-populated menulists

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Aakash Desai [:aakashd]]

Build Id:
Mozilla/5.0 (X11; U; Linux armv7l; Nokia N900; en-US; rv:1.9.2.3pre) Gecko/20100401 Namoroka/3.6.3pre Fennec/1.1a2pre

Steps to Reproduce:
1. Go to graphs.mozilla.org
2. Before the menulists are finished populating (i.e. the menulist boxes do not show "All"), click on one of them (i.e. http://www.flickr.com/photos/42893104@N04/4483008772/ )

Actual Results:
The form helper will pop-up with the blackground, but with no options

screenshot: http://www.flickr.com/photos/42893104@N04/4482359835/

Expected Results:
The form helper should not pop-up unless there are options available to select from a menulist.

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

Not sure that this is blocking...

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

Hmm, now that I think about it - don't we want to show the user that the list is empty? In your example on desktop, if you click on the selects as the page is loading, you see an empty box.

Maybe we should just show an empty white area?

Comment 3

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: Patch

After discussion on IRC we want to show one blank line.
This patch also correct a regression found by fabrice, which is when a "select" has many elements the box can outstrip the screen.

Comment 4

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 438102 [details] [diff] [review]
Patch

>diff -r fdc68b301924 chrome/content/browser.xul

>     <!-- options dialog for select form field -->
>     <vbox id="select-container" hidden="true" pack="center">
>-      <vbox id="select-container-inner" class="dialog-dark">
>+      <spacer flex="1000"/>
>+      <vbox id="select-container-inner" class="dialog-dark" flex="1">

>+      <spacer flex="1000"/>

You set the <vbox> to -moz-box-flex: 0 in CSS. Why the difference?
You set the <spacer>s to display:none in the CSS. What affect do they have?

Comment 5

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

(In reply to comment #4)
> (From update of attachment 438102 [details] [diff] [review])
> >diff -r fdc68b301924 chrome/content/browser.xul
> 
> >     <!-- options dialog for select form field -->
> >     <vbox id="select-container" hidden="true" pack="center">
> >-      <vbox id="select-container-inner" class="dialog-dark">
> >+      <spacer flex="1000"/>
> >+      <vbox id="select-container-inner" class="dialog-dark" flex="1">
> 
> >+      <spacer flex="1000"/>
> 
> You set the <vbox> to -moz-box-flex: 0 in CSS. Why the difference?
> You set the <spacer>s to display:none in the CSS. What affect do they have?

Sorry I've not been enough explicit for that.

Fabrice has found a regression introduce by bug 556875  which, when there is many elements in the original <menulist/>, end to have our custom select be bigger than the screen and this only happen for the _chrome_ select, not the web's one.
So, I've put back some "flex" attributes on these elements to correct this regression that I removing for the _web_ select.

Comment 6

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 438102 [details] [diff] [review]
Patch

The fact we re-parent the select-container was throwing me for a while

Comment 7

[Mark Finkle (:mfinkle) (use needinfo?)]

pushed:
http://hg.mozilla.org/mobile-browser/rev/40906e9d5793

Comment 8

[Aakash Desai [:aakashd]]

verified FIXED On builds:

Mozilla/5.0 (X11; U; Linux armv7l; Nokia N900; en-US; rv:1.9.2.4pre) Gecko/20100413 Namoroka/3.6.4pre Fennec/1.1a2pre

and

Mozilla/5.0 (X11; U; Linux armv6l; en-US; rv:1.9.3a4pre) Gecko/20100413 Namoroka/3.7a4pre Fennec/1.1a2pre



follow-up bug filed for the the fact that an empty menulist box looks like the autocomplete/formfill bar in bug 559069