Closed
Bug 556707
Opened 14 years ago
Closed 12 years ago
STL: Should _SECURE_SCL be disabled in OPT builds?
Categories
(Core :: XPCOM, enhancement)
Core
XPCOM
Tracking
()
RESOLVED
INVALID
People
(Reporter: cjones, Unassigned)
References
(Blocks 1 open bug, )
Details
_SECURE_SCL enables bounds-checked iterators for STL containers. It's enabled by default in all build configurations for MSVC. However, gcc doesn't do that, and nsTArray doesn't do bounds checking in OPT builds. Currently I've left it enabled because of some build issues, but those are easy to fix. The question is: would we see an appreciable perf benefit by disabling _SECURE_SCL? If not, I can't think of any argument for not bounds-checking iterators.
Comment 1•12 years ago
|
||
Do we build our own CRT on Windows these days?
No.
Comment 3•12 years ago
|
||
So this bug doesn't make sense any more.
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → INVALID
You need to log in
before you can comment on or make changes to this bug.
Description
•