Remove copyright strings in UI

VERIFIED FIXED

Status

Firefox for Android Graveyard
General
VERIFIED FIXED
8 years ago
8 years ago

People

(Reporter: flod, Assigned: Alexander L. Slovesnik)

Tracking

Fennec 1.1

Details

(URL)

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

8 years ago
In locales/en-US/chrome/about.dtd, aboutPage.copyrightInfo1 is "©1998-2009 Contributors. All rights reserved. (". It should be "1998-2010".

Consider also that copyright dates have been removed from /browser in bug 536336.
Yeah, I think we can just get rid of that entire string, per bug 536336.
Summary: Copyright years in about.dtd should be updated to 2010 or removed → copyright stuff in about.dtd should be removed
(Assignee)

Comment 2

8 years ago
Created attachment 436709 [details] [diff] [review]
Patch v.1
Attachment #436709 - Flags: review?(gavin.sharp)
(Assignee)

Updated

8 years ago
Summary: copyright stuff in about.dtd should be removed → Remove copyright strings in UI
(Assignee)

Comment 3

8 years ago
Created attachment 436711 [details] [diff] [review]
Patch v.2

Without new line in InfoPlist.strings.in
Attachment #436709 - Attachment is obsolete: true
Attachment #436711 - Flags: review?(gavin.sharp)
Attachment #436709 - Flags: review?(gavin.sharp)
Comment on attachment 436711 [details] [diff] [review]
Patch v.2

thanks!
Attachment #436711 - Flags: review?(gavin.sharp) → review+

Comment 5

8 years ago
We shouldn't land this before the beta builds are wrapped up, and then triage if this should land for 1.1 or later.
(Assignee)

Updated

8 years ago
Assignee: nobody → unghost
Status: NEW → ASSIGNED
(Reporter)

Comment 6

8 years ago
(doing some cleanup on the bugs I reported) Should we land this one? The patch seems to be still valid, since no changes were applied to that file since bug 512843
(Assignee)

Comment 7

8 years ago
Comment on attachment 436711 [details] [diff] [review]
Patch v.2

Axel have said on irc that mobile drivers should decide if this patch still wanted, so I'll request additional review.
Attachment #436711 - Flags: review?(mark.finkle)
Comment on attachment 436711 [details] [diff] [review]
Patch v.2

Looks fine to me
Attachment #436711 - Flags: review?(mark.finkle) → review+
(Assignee)

Updated

8 years ago
Keywords: checkin-needed
(Assignee)

Comment 9

8 years ago
Can someone help with landing this patch, if it still needed for Fennec. This patch lays here with "checkin-needed" status for 6 months already.
Marked as blocking for final release.
tracking-fennec: --- → ?
I meant request for blocking for the final release.
We should hold off on this, because I think Fennec probablys needs the fix for bug 569057 as well, and we should only change the entity once.
Keywords: checkin-needed
tracking-fennec: ? → 2.0b3+
OK, this is good to go as-is.
Keywords: checkin-needed
Keywords: checkin-needed
Whiteboard: [fennec-checkin-postb2]
pushed:
http://hg.mozilla.org/mobile-browser/rev/f70e43fbc78f
Status: ASSIGNED → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
Whiteboard: [fennec-checkin-postb2]
Verified:
Mozilla/5.0 (Maemo;Linux armv71; rv:2.0b8pre) Gecko/20101104 Firefox/4.0b8pre Fennec/4.0b3pre
Mozilla/5.0 (Android; Linux armv71; rv2.0b8pre) Gecko/20101104 Firefox/4.0b8pre Fennec/4.0b3pre
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.