Closed
Bug 556716
Opened 14 years ago
Closed 14 years ago
Remove copyright strings in UI
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(fennec2.0b3+)
VERIFIED
FIXED
| Tracking | Status | |
|---|---|---|
| fennec | 2.0b3+ | --- |
People
(Reporter: flod, Assigned: unghost)
References
()
Details
Attachments
(1 file, 1 obsolete file)
|
4.47 KB,
patch
|
Gavin
:
review+
mfinkle
:
review+
|
Details | Diff | Splinter Review |
In locales/en-US/chrome/about.dtd, aboutPage.copyrightInfo1 is "©1998-2009 Contributors. All rights reserved. (". It should be "1998-2010".
Consider also that copyright dates have been removed from /browser in bug 536336.
|
||
Comment 1•14 years ago
|
||
Yeah, I think we can just get rid of that entire string, per bug 536336.
Summary: Copyright years in about.dtd should be updated to 2010 or removed → copyright stuff in about.dtd should be removed
|
Assignee | |
Comment 2•14 years ago
|
||
Attachment #436709 -
Flags: review?(gavin.sharp)
|
|
Assignee | |
Updated•14 years ago
|
Summary: copyright stuff in about.dtd should be removed → Remove copyright strings in UI
|
|
Assignee | |
Comment 3•14 years ago
|
||
Without new line in InfoPlist.strings.in
Attachment #436709 -
Attachment is obsolete: true
Attachment #436711 -
Flags: review?(gavin.sharp)
Attachment #436709 -
Flags: review?(gavin.sharp)
|
|
||
Comment 4•14 years ago
|
||
Comment on attachment 436711 [details] [diff] [review] Patch v.2 thanks!
Attachment #436711 -
Flags: review?(gavin.sharp) → review+
|
||
Comment 5•14 years ago
|
||
We shouldn't land this before the beta builds are wrapped up, and then triage if this should land for 1.1 or later.
|
|
Assignee | |
Updated•14 years ago
|
Assignee: nobody → unghost
Status: NEW → ASSIGNED
|
Reporter | |
Comment 6•14 years ago
|
||
(doing some cleanup on the bugs I reported) Should we land this one? The patch seems to be still valid, since no changes were applied to that file since bug 512843
|
|
Assignee | |
Comment 7•14 years ago
|
||
Comment on attachment 436711 [details] [diff] [review] Patch v.2 Axel have said on irc that mobile drivers should decide if this patch still wanted, so I'll request additional review.
Attachment #436711 -
Flags: review?(mark.finkle)
|
||
Comment 8•14 years ago
|
||
Comment on attachment 436711 [details] [diff] [review] Patch v.2 Looks fine to me
Attachment #436711 -
Flags: review?(mark.finkle) → review+
|
|
Assignee | |
Updated•14 years ago
|
Keywords: checkin-needed
|
|
Assignee | |
Comment 9•14 years ago
|
||
Can someone help with landing this patch, if it still needed for Fennec. This patch lays here with "checkin-needed" status for 6 months already.
Marked as blocking for final release.
tracking-fennec: --- → ?
I meant request for blocking for the final release.
|
|
||
Comment 12•14 years ago
|
||
We should hold off on this, because I think Fennec probablys needs the fix for bug 569057 as well, and we should only change the entity once.
|
|
||
Updated•14 years ago
|
Keywords: checkin-needed
|
|
||
Updated•14 years ago
|
tracking-fennec: ? → 2.0b3+
|
|
||
Updated•14 years ago
|
Keywords: checkin-needed
Whiteboard: [fennec-checkin-postb2]
|
|
||
Comment 14•14 years ago
|
||
pushed: http://hg.mozilla.org/mobile-browser/rev/f70e43fbc78f
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
|
|
||
Updated•14 years ago
|
Whiteboard: [fennec-checkin-postb2]
Verified: Mozilla/5.0 (Maemo;Linux armv71; rv:2.0b8pre) Gecko/20101104 Firefox/4.0b8pre Fennec/4.0b3pre Mozilla/5.0 (Android; Linux armv71; rv2.0b8pre) Gecko/20101104 Firefox/4.0b8pre Fennec/4.0b3pre
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•