Closed Bug 556721 Opened 12 years ago Closed 10 years ago

Clean up Places tests

Categories

(Toolkit :: Places, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: mak, Unassigned)

References

Details

Attachments

(1 file)

Now that bug 556376 landed we cna remove a bunch of boilerplate code from xpcshell tests, and make them more consistent.

All patches will have blanket-rs=places-team and changesets will be annotated here
Assignee: nobody → mak77
Status: NEW → ASSIGNED
cleanup of test_adaptive.js
http://hg.mozilla.org/mozilla-central/rev/cee6b068564f
Summary: Clean up Place xpcshell tests → Clean up Places xpcshell tests
unassigning since it's a global team bug.
Assignee: mak77 → nobody
Status: ASSIGNED → NEW
converting to collect changesets for generic Places tests.
Summary: Clean up Places xpcshell tests → Clean up Places tests
this just needs a rubberstamp
Attachment #518732 - Flags: review?(sdwilsh)
Assignee: nobody → mak77
Comment on attachment 518732 [details] [diff] [review]
cleanup test_browserGlue_migrate.js [checked-in]

r=sdwilsh
Attachment #518732 - Flags: review?(sdwilsh) → review+
Comment on attachment 518732 [details] [diff] [review]
cleanup test_browserGlue_migrate.js [checked-in]

http://hg.mozilla.org/projects/places/rev/2b7578c84821
Attachment #518732 - Attachment description: cleanup test_browserGlue_migrate.js → cleanup test_browserGlue_migrate.js [checked-in]
test_342484.xul, cleaned up and removed dependency on a positive setTimeout
http://hg.mozilla.org/projects/places/rev/024f5e4df8d5
Cleanup test_update_frecency_after_delete.js and test_412132.js
http://hg.mozilla.org/projects/places/rev/a2f4b2f63393
Remove flaky timeout from browser_library_panel_leak.js
http://hg.mozilla.org/projects/places/rev/04753538e3b6
Assignee: mak77 → nobody
This just cleanups the tests connection in those rare cases it is used, if something should use it for async stuff, it may bring to unwanted warnings and bad stuff.
http://hg.mozilla.org/projects/places/rev/52912e2fcd84
Avoid deprecated octal warnings in head_common.js
http://hg.mozilla.org/projects/places/rev/95203f83bc25
should this be closed now?
yeah, better.
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.