Status

()

Toolkit
Places
RESOLVED FIXED
8 years ago
6 years ago

People

(Reporter: mak, Unassigned)

Tracking

Trunk
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

8 years ago
Now that bug 556376 landed we cna remove a bunch of boilerplate code from xpcshell tests, and make them more consistent.

All patches will have blanket-rs=places-team and changesets will be annotated here
(Reporter)

Updated

8 years ago
Assignee: nobody → mak77
Status: NEW → ASSIGNED
(Reporter)

Comment 1

8 years ago
cleanup of test_adaptive.js
http://hg.mozilla.org/mozilla-central/rev/cee6b068564f
(Reporter)

Updated

8 years ago
Summary: Clean up Place xpcshell tests → Clean up Places xpcshell tests
(Reporter)

Comment 2

7 years ago
unassigning since it's a global team bug.
Assignee: mak77 → nobody
(Reporter)

Updated

7 years ago
Status: ASSIGNED → NEW
(Reporter)

Comment 3

7 years ago
converting to collect changesets for generic Places tests.
Summary: Clean up Places xpcshell tests → Clean up Places tests
(Reporter)

Comment 6

7 years ago
Created attachment 518732 [details] [diff] [review]
cleanup test_browserGlue_migrate.js [checked-in]

this just needs a rubberstamp
Attachment #518732 - Flags: review?(sdwilsh)

Updated

7 years ago
Assignee: nobody → mak77
Comment on attachment 518732 [details] [diff] [review]
cleanup test_browserGlue_migrate.js [checked-in]

r=sdwilsh
Attachment #518732 - Flags: review?(sdwilsh) → review+
(Reporter)

Comment 8

7 years ago
Comment on attachment 518732 [details] [diff] [review]
cleanup test_browserGlue_migrate.js [checked-in]

http://hg.mozilla.org/projects/places/rev/2b7578c84821
Attachment #518732 - Attachment description: cleanup test_browserGlue_migrate.js → cleanup test_browserGlue_migrate.js [checked-in]
(Reporter)

Comment 9

7 years ago
test_342484.xul, cleaned up and removed dependency on a positive setTimeout
http://hg.mozilla.org/projects/places/rev/024f5e4df8d5
(Reporter)

Comment 10

7 years ago
merged to central
test_browserGlue_migrate.js: http://hg.mozilla.org/mozilla-central/rev/2b7578c84821
test_342484.xul
http://hg.mozilla.org/mozilla-central/rev/024f5e4df8d5
(Reporter)

Comment 11

7 years ago
Cleanup test_update_frecency_after_delete.js and test_412132.js
http://hg.mozilla.org/projects/places/rev/a2f4b2f63393
Remove flaky timeout from browser_library_panel_leak.js
http://hg.mozilla.org/projects/places/rev/04753538e3b6
(Reporter)

Updated

7 years ago
Assignee: mak77 → nobody
(Reporter)

Comment 13

7 years ago
This just cleanups the tests connection in those rare cases it is used, if something should use it for async stuff, it may bring to unwanted warnings and bad stuff.
http://hg.mozilla.org/projects/places/rev/52912e2fcd84
(Reporter)

Comment 14

7 years ago
Avoid deprecated octal warnings in head_common.js
http://hg.mozilla.org/projects/places/rev/95203f83bc25
should this be closed now?
(Reporter)

Comment 17

6 years ago
yeah, better.
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.