556758 - Remove close button dead space in toolbar

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: patch

Currently, Fennec uses visibility: hidden to show/hide the close button in the URL toolbar. This means a dead space is created when the close button is not shown and the app is not running fullscreen or a full screen dialog is not open. Originally, we did this to keep the URL edit box from growing/shrinking as the close button became visible.

On the N900 the dead space should never happen. The app runs fullscreen all the time, so the button is always visible.

On desktop and Android the dead space is more apparent.

This patch switches to visibility: collapse so the dead space goes away. The URL edit box does grow/shrink, but that might be of less concern.

Comment 1

[Madhava Enros [:madhava]]

On Android, we'll likely use the hardware back button to exit from full screen
dialogs, so we won't need the back button in the awesomescreen anyway.

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

pushed:
http://hg.mozilla.org/mobile-browser/rev/0d6158cef87d

We can add the android changes in a new bug.