556814 - KeyError: u'reg'

Status: RESOLVED FIXED

(addons.mozilla.org Graveyard :: Localization, defect, P1)

Description

[Jeff Balogh (:jbalogh)]

This is the same as bug 554696, but now I know the problem!

We crash inside this {% trans %} block: http://github.com/jbalogh/zamboni/blob/master/apps/addons/templates/addons/tags_box.html#L26

...because the msgstr does not match: http://github.com/clouserw/amo-locales/blob/master/de/LC_MESSAGES/messages.po#L1154

So, is this a php2pypo problem?  Or a localizer issue?  Or did we change the variable name and the string got fuzzy matched?

Comment 1

[Wil Clouser [:clouserw]]

Attachment: fallback

php2pypo only fills in msgid's and fuzzy matching is disabled, so this is from the localizer.

I'm attaching a patch that fixes it in Tower's tests (basically, catch the error and fall back to english).  Also, please add an __init__ to jingo's tests dir.

Comment 2

[Wil Clouser [:clouserw]]

Attachment: fallback for reals

Alright, here's a patch for the actual code instead of the tests.  I added a test to tower to catch this.

Comment 3

[Wil Clouser [:clouserw]]

"-e git://github.com/clouserw/tower.git#egg=tower" didn't make it into the patch...

Comment 4

[Jeff Balogh (:jbalogh)]

Comment on attachment 436807 [details] [diff] [review]
fallback for reals

Thanks for picking this up.  I think the test should go in jingo, and the `except` should be catching a specific exception, not all of them.

Comment 5

[Wil Clouser [:clouserw]]

Attachment: move the test

Needs `git apply` for the .mo

Comment 6

[Jeff Balogh (:jbalogh)]

Comment on attachment 437057 [details] [diff] [review]
move the test

Thanks!

Comment 7

[Wil Clouser [:clouserw]]

http://github.com/jbalogh/jingo/commit/c73d2c55182301e6f3ce507fc9a17ea843fed24f