Closed
Bug 556879
Opened 16 years ago
Closed 16 years ago
JSRuntime::gcIsNeeded is needed after all
Categories
(Core :: JavaScript Engine, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: jorendorff, Assigned: jorendorff)
Details
(Whiteboard: fixed-in-tracemonkey)
Attachments
(1 file, 1 obsolete file)
|
639 bytes,
patch
|
igor
:
review+
|
Details | Diff | Splinter Review |
Patch coming to kill it.
|
Assignee | |
Comment 1•16 years ago
|
||
The one place where gcIsNeeded was set was removed without comment in:
http://hg.mozilla.org/tracemonkey/rev/487b81c753c0
Maybe that was accidental, though?
If not, here's the patch to wipe out the remaining mentions of gcIsNeeded. It's always false.
Assignee: general → jorendorff
Attachment #436775 -
Flags: review?(igor)
|
|
||
Comment 2•16 years ago
|
||
(In reply to comment #1)
> The one place where gcIsNeeded was set was removed without comment in:
> http://hg.mozilla.org/tracemonkey/rev/487b81c753c0
>
> Maybe that was accidental, though?
It was my bad, thanks for finding it. That was accidental due to bad merge and should be restored.
|
|
Assignee | |
Updated•16 years ago
|
Attachment #436775 -
Flags: review?(igor)
|
|
Assignee | |
Comment 3•16 years ago
|
||
Here's the patch to restore that.
Attachment #436775 -
Attachment is obsolete: true
Attachment #437295 -
Flags: review?(igor)
|
|
||
Comment 4•16 years ago
|
||
Comment on attachment 437295 [details] [diff] [review]
v2
Yes, that should be restored.
Attachment #437295 -
Flags: review?(igor) → review+
|
|
Assignee | |
Comment 5•16 years ago
|
||
Summary: JSRuntime::gcIsNeeded is not needed → JSRuntime::gcIsNeeded is needed after all
Whiteboard: fixed-in-tracemonkey
|
||
Comment 6•16 years ago
|
||
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•