Closed Bug 556930 Opened 14 years ago Closed 14 years ago

Wrong secret phrase warning shows up when logging in

Categories

(Firefox :: Sync, defect)

Product:
Firefox
Component:
Sync
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
VERIFIED FIXED

People

(Reporter: Mardak, Assigned: mconnor)

References

Details

Attachments

(1 file)

v1
5.59 KB, patch
Mardak
: review+
Details | Diff | Splinter Review 
Bug 545725 doesn't short circuit on the passphrase failure, so the UI needs to know that this is an intermediate failure somehow. Except it's the status bar showing this failure and not the fx-prefs.
Assignee: nobody → mconnor
Target Milestone: --- → 1.3
Attached patch v1 — — Splinter Review 
This is bigger than I intended it to be, but I'm going to use the new const elsewhere.
Attachment #440240 - Flags: review?(edilee)
Comment on attachment 440240 [details] [diff] [review]
v1

Go zpao! ;)
Attachment #440240 - Flags: review?(edilee) → review?(paul)
Comment on attachment 440240 [details] [diff] [review]
v1

>+++ b/source/modules/status.js
>+    if (code == LOGIN_FAILED_NETWORK_ERROR || code == LOGIN_FAILED_SERVER_ERROR)
>       this.service = LOGIN_FAILED;
>+    else if (code != LOGIN_SUCCEEDED) // missing/wrong user/pass/pp
>+      this.service = CLIENT_NOT_CONFIGURED;
Mm.. This should be fine other than the corner case from bug 560260 where a totally bogus username (email address) results in a 400 -> SERVER_ERROR.
Attachment #440240 - Flags: review?(paul) → review+
Yeah, we'll need to fix that bug eventually (soon).
http://hg.mozilla.org/labs/weave/rev/5f13b8381818
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Target Milestone: 1.3 → 1.3b1
verified with 1.3b5
Status: RESOLVED → VERIFIED
Component: Firefox Sync: UI → Sync
Product: Cloud Services → Firefox
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: