556962 - Maemo geolocation provider is not compiling on Maemo 6.

Status: RESOLVED WONTFIX

(Core :: DOM: Geolocation, defect)

Description

[Oleg Romashin (:romaxa)]

Attachment: Set maemo5 ifdef for geolocation provider

liblocation-dev library is missing due unknown reasons, and we are not checking for availability of that library and headers.

Comment 1

[Doug Turner (:dougt)]

Comment on attachment 436842 [details] [diff] [review]
Set maemo5 ifdef for geolocation provider

Do we know if the dependency problem is a bug in the SDK you are using and it will be fixed shortly?

Comment 2

[Oleg Romashin (:romaxa)]

Attachment: Better fix

This should be a better version

Comment 3

[Doug Turner (:dougt)]

Comment on attachment 438520 [details] [diff] [review]
Better fix

is liblocation specific to maemo?

Comment 4

[Oleg Romashin (:romaxa)]

(In reply to comment #3)
> (From update of attachment 438520 [details] [diff] [review])
> is liblocation specific to maemo?

I think yes, at least I have not seen it in any other distro...

Comment 5

[Doug Turner (:dougt)]

Oleg, please add a AC_MSG_WARN if we fail to find liblocation in maemo

Comment 6

[Oleg Romashin (:romaxa)]

Attachment: added warning

Comment 7

[Doug Turner (:dougt)]

Comment on attachment 438531 [details] [diff] [review]
added warning

ted is out for a while.

Comment 8

[Oleg Romashin (:romaxa)]

Pushed in
http://hg.mozilla.org/mozilla-central/rev/f395426b49ab

Comment 9

[(not currently active) Ted Mielczarek]

This goes against the way we like configure tests to work. If a dependency is missing, we should fail in configure with an AC_MSG_ERROR, and tell the user what they can --disable to build without whatever feature requires this, and also indicate what packages they should install if they want to use this feature. Silently disabling features is not the right thing to do. Can you make a followup patch to error with a useful message?

Comment 10

[Doug Turner (:dougt)]

Oleg, sorry about that.  Comment 5 should be: 

AC_MSG_WARN -> AC_MSG_ERROR

Comment 11

[Chris Peterson [:cpeterson]]

Firefox no longer supports Maemo.