Project tabs height improperly set

RESOLVED WONTFIX

Status

Websites Graveyard
www.drumbeat.org
P1
major
RESOLVED WONTFIX
8 years ago
3 years ago

People

(Reporter: Ned Schwartz, Assigned: Campbell Vertesi)

Tracking

Details

(URL)

Attachments

(1 attachment)

(Reporter)

Description

8 years ago
There is a bug in the javascript somewhere that is setting the tabs to the wrong height.

This appeared after tellon svn r289: which is a resolution for bug 556827
(Reporter)

Comment 1

8 years ago
it looks like the javascript is inserting an extra "row" of height for tabs:

- the tabs are 40px high, 
- if there is one row of tabs the #tabs-wrapper is set to a height of 80px
- if there are 2 rows of tabs, the #tabs-wrapper is set to a height of 120px

thus: it seems the script is calculating the height of #tabs-wrapper as 2(row-height) + row-height.
the correct formula would be 2(row-height)
(Reporter)

Updated

8 years ago
Severity: normal → major
(Reporter)

Comment 2

8 years ago
Created attachment 436929 [details]
Screenshot of the improper #tabs-wrapper height 

This screenshot shows how the bug looks
(Reporter)

Comment 3

8 years ago
I did some tweaks to the css styling on the tabs and now the problem looks less severe - still a serious display issue. 

The miscalculation still seems to be off by a constant amount, but it is now not an entire row-height off; seems like it might be off by the height of padding+border. So, something like:

2(row-height) + (#tabs-wrapper.padding-top + #tabs-wrapper.padding-bottom + #tabs-wrapper.border-top + #tabs-wrapper.border-bottom)

again, should just be:

2(row-height).
(Reporter)

Updated

8 years ago
See Also: → bug 556827
(Reporter)

Comment 4

8 years ago
I would love to be able to work on the javascript myself, but am still not able to do so. One way to resolve this (and enable me to fix a bunch of other stuff!) is if someone form trellon could help me to get started working on the js.
Status: NEW → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → WONTFIX
Product: Websites → Websites Graveyard
You need to log in before you can comment on or make changes to this bug.