Command-M doesn't minimize window of Mac

RESOLVED FIXED

Status

Mozilla Labs
Prism
RESOLVED FIXED
8 years ago
8 years ago

People

(Reporter: Matthew Gertner, Assigned: Matthew Gertner)

Tracking

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

8 years ago
Standard behavior for apps on OS X is for Command-M to minimize the active application window. This currently doesn't work in Prism.
(Assignee)

Comment 1

8 years ago
Created attachment 436931 [details] [diff] [review]
Add commandset/keyset for window minimize to main browser XUL
Attachment #436931 - Flags: review?(mark.finkle)
(Assignee)

Updated

8 years ago
Duplicate of this bug: 492565
Comment on attachment 436931 [details] [diff] [review]
Add commandset/keyset for window minimize to main browser XUL

>Index: chrome/locale/en-US/browser/baseMenuOverlay.dtd
>===================================================================
>--- chrome/locale/en-US/browser/baseMenuOverlay.dtd	(revision 0)
>+++ chrome/locale/en-US/browser/baseMenuOverlay.dtd	(revision 0)
>@@ -0,0 +1,41 @@
>+<!ENTITY minimizeWindow.key       "m">
>+<!ENTITY minimizeWindow.label     "Minimize">
Why bring in this whole file for just 2 strings? Why not just add the two string to webrunner.dtd?

>Index: chrome/content/webrunner.xul

>+#ifdef XP_MACOSX
>+  <commandset id="baseMenuCommandSet">
>+    <command id="minimizeWindow"
>+      label="&minimizeWindow.label;"
>+      oncommand="window.minimize();" />
>+  </commandset>
>+
>+  <keyset id="baseMenuKeyset">
>+     <key id="key_minimizeWindow"
>+        command="minimizeWindow"
>+        key="&minimizeWindow.key;"
>+        modifiers="accel"/>
>+  </keyset>
>+#endif

Why not put these in the existing commandset and keyset?
(Assignee)

Comment 4

8 years ago
Created attachment 437285 [details] [diff] [review]
Move command and key to existing commandset/keyset
Attachment #436931 - Attachment is obsolete: true
Attachment #437285 - Flags: review?(mark.finkle)
Attachment #436931 - Flags: review?(mark.finkle)
Attachment #437285 - Flags: review?(mark.finkle) → review+
(Assignee)

Comment 5

8 years ago
Sending        chrome/content/webrunner.xul
Sending        chrome/jar.mn
Adding         chrome/locale/en-US/browser/baseMenuOverlay.dtd
Transmitting file data ...
Committed revision 65844.
Status: ASSIGNED → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.