Closed Bug 557202 Opened 15 years ago Closed 14 years ago

unable to upload theme ( developers.js JSON.parse error ) ( error -228 , error -261 )

Categories

(addons.mozilla.org Graveyard :: Developer Pages, defect)

Product:
addons.mozilla.org Graveyard
Component:
Developer Pages
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED WORKSFORME

People

(Reporter: mcdavis941.bugs, Unassigned)

Details

Attachments

(5 files)

saved jar containing add-on not found page
587 bytes, text/plain
Details
The relevant JAR
1.80 MB, application/java-archive
Details
screenshot showing three copies of new version created
37.21 KB, image/png
Details
some users error reports from february, march and april
365.66 KB, image/png
Details
screenshot of "oops problem with file" and resulting multiple versions created
84.17 KB, image/png
Details
I've been trying to upload a new version of addon 4908 (a theme) but the upload is failing silently. After selecting a file and clicking upload, the spinner spins and (watching network traffic) the right number of bytes seems to go across, but then the spinner disappears and the transaction doesn't go any further. Where it would usually give the validation report, it just stops. I can upload to one of my extensions so it seems specific to either 4908 or to themes in general. https://addons.mozilla.org/en-US/developers/versions/add/4908 This shows up in the Error Console: Error: JSON.parse Source file: https://addons.mozilla.org/js/developers.js Line: 385
Summary: unable to upload theme → unable to upload theme ( developers.js JSON.parse error )
Morphing this bug to reflect current situation. Note: this bug is talking about a _beta_ version, not the main release channel for the add-on. Current situation: - was eventually able to upload the update to the beta channel - for a brief period of time (minutes), was able to install the update from AMO - now, all attempts to update fail with error - note that the "available for a while, but then not" seems like the same thing described in Bug 544587 comment 19. ---- Update through Addons Mgr check updates: Firefox could not install the file at http://releases.mozilla.org/pub/mozilla.org/addons/4908/nasa_night_launch-0.6.20100405beta-fx.jar because: Download error -228 Install from click on AMO beta link: Firefox could not install the file at https://addons.mozilla.org/en-US/firefox/downloads/file/85711/nasa_night_launch-0.6.20100405beta-fx.jar?src=beta-addon-detail because: Invalid file hash (possible download corruption) -261 With MR Tech Toolkit, right-click on AMO beta-version install link, click archive JAR: Saves a 1K file containing unrecognized binary content Simple right-click on AMO beta-version install link, Save link as ...: Saves the "Add-on not found!" error page, see next attachment ----
Morphing title to add error codes -228 and -261 Also CCing some people, apologies if I get the wrong people.
Summary: unable to upload theme ( developers.js JSON.parse error ) → unable to upload theme ( developers.js JSON.parse error ) ( error -228 , error -261 )
Maybe also worth noting, after the add-on upload finally succeeded, there were three copies of it listed under 'Versions and Files' for the add-on. This was after maybe 15 to 25 upload attempts. One of the three copies was listed as (I don't recall exactly) an empty version or version with no file. I deleted that one and one of the other two, which brings us to where we are now.
The JSON.parse error looks like part of what's in bug 522554 and bug 520219.
Component: Public Pages → Developer Pages
QA Contact: web-ui → developers
Please attach the file that caused this error. Thanks.
OS: Windows Vista → All
Hardware: x86 → All
I've been holding off on uploading any new versions in case AMO developers want to gather data from this case. It's getting to be time for the next update -- is there anyone trying to use this as a live sample of an update that didn't work? Or can I go ahead and update?
I would try uploading the new version. I ran your attached add-on through the validator (https://addons.mozilla.org/en-US/developers/addon/validate) which is the most likely point of failure and it worked.
OK, thanks a lot for the info.
A couple more data points: - on or around the 15th, tried to upload a beta version, which failed silently (stopped after transfer, validation did not run, created a new version with no associated file) - decided just to come back and try again later - on the 17th, a few minutes ago, tried to upload a beta version, which worked perfectly - also uploaded one for the release channel, and that worked perfectly too
More data: The beta update continues to look successful. The release channel update, however, started returning -228 after a couple hours on the 17th, so I retracted (deleted) that update on the afternoon on the 17th. I uploaded to the release channel again on the morning of the 18th. The upload seemed to work normally. However, as before, it was first available, then not, and began returning -228 after a couple hours on the 18th. I let it sit overnight, to give it time to work its way out to the mirrors. It's now been about 20 hours since the upload and users are still reporting -228, and I can't install it either. I'm deleting this update again.
Are you testing from an ipv6-enabled connection by any chance?
I think no. I turned it off when I first set up this machine, and, looking now (Win Vista 64-bit) the IPv6 driver is disabled under network properties, and running ipconfig shows only an IPv4 address.
ok, just checking... we monitor the mirrors in the releases pool, except there's a few of them on IPv6 and we don't have IPv6 available on our end via which to monitor them, so it was potentially giving me somewhere to look if that was the case.
(In reply to comment #15) > potentially giving me somewhere to look if > that was the case. oh, i see what you mean. it would have been nice if that was it.
This morning I tried an update to the beta channel from a fresh profile with only Noscript and Adblock Plus installed. My other profile, the one I've been using all along, is years old and has dozens of add-ons. AMO cookies don't always work right for me (they're supposed to last a year, right?) and I seem to get logged out sooner than I should, sometimes in the middle of an active session of browsing through my developer pages. I've suspected some kind of interference from an add-on. So, it seemed worth a shot to try with a fresh profile, but the behavior was what I've seen before. An error while updating, and three copies of the update file created. The screenshot shows what happened.
Everything else I can think of that might have any bearing at all: 1. cookie problems, as mentioned in comment 17, maybe caused by being logged in / accessing AMO through multiple browser instances at the same time (multi-platform testing of add-ons) 2. could 32-bit firefox on 64-bit vista have a cookie problem? i would think not -- last time i checked, 64-bit was not an officially-supported platform for firefox, but i suspect quite a few people are using it and would have noticed a problem. 3. theme, larger, trusted, older: a seldom-used code path? 4. is there something in my database records that needs scrubbing? it's an older add-on and an older account. maybe those records picked up some bad values along the way, or something that doesn't match current expectations of the code. 5. timing issues because it's a larger file 6. not picking up a permission because it's a trusted submission, and therefore not being marked as editor-approved? 7. sometime earlier this year or toward the end of last year i tried to switch how the contribution page shows post-install (from whatever it is to one of the other options) but my changes were ignored. if you want to do some kind of tests (i upload, you watch what happens), at a specific arranged time, i could do that.
Can you summarize what the problem is? It looks like your latest version and latest beta are both live on the site.
(In reply to comment #20) > Can you summarize what the problem is? It looks like your latest version and > latest beta are both live on the site. You're right about the beta version, although the currently-available 0.6.20100314 release is an older one, after I retracted the latest release. I'd like to release 0.6.20100415. To summarize, the problem is that, since my last hassle-free update in January, there's been some error 90% of the time when I attempt to upload and distribute a new add-on version for 4908. Specifically, those errors are: - the JSON.parse error for which this bug was first filed (observed twice) - file appears to transfer (watching net usage) but upload page goes no further (observed multiple times) - validation begins but doesn't complete (observed multiple times) - validation completes but reports an error while copying files (observed multiple times) - validation completes and reports success, but duplicate add-on files are created for the new version (observed multiple times) - regardless of success or failure (it's hard to tell - is it successful when duplicate files are created?), a new add-on version is created, but attempts to download/install it generate an error -228, or -261 (observed multiple times) - the failure mode for -228 seems to be that the new update is first available (for some minutes after I upload it) and then unavailable after that Again to summarize: - the upload hardly ever works, but eventually it will if I keep trying - it's hard to tell if it worked or not - even when the upload "works", it frequently results in errors for users trying to install it The thing with the AMO cookie/unexpected logout is separate, although may be related. The reason I mentioned it is that it seems like if the site decided I had logged out while I was in the middle of an upload, that might account for an incomplete upload. To say a little about the impact: this has become really bad for me. Making a release has turned into a minor ordeal, and I have to spend hours nursing a new version through the upload process and checking to make sure it's actually going out to users. Also, I don't know what percentage of attempted installs turn into errors, but thousands of people install this every day. Given the largish number of people using this add-on, I cringe at the idea of how this must make Firefox and the add-on look. I'm basically blocked from issuing new updates unless I want to risk inflicting a slew of new install errors. That's why I'm hoping we can figure something out here. (Even if the answer is "it'll be fixed in Zamboni".) I realize I may be conflating separate errors or that aspects that were problems in the past may now be fixed, and that the problem may well be on my end.
Just to show that people (some more snarky than others) in the general user population are seeing these errors.
FWIW, here's the latest. I haven't done anything since last reporting in this bug. Today I tried to upload 0.6.20100415, unsuccessfully. I tried five times, and each time it was the same: - on upload new version page, picked the file - spinner spun for about 20 seconds then stopped and disappeared - page did not progress to the next step - no new version was created
On Friday morning 2010-04-30 I tried again to upload without success. The bustage was the same as on the previous day: pick file, start upload, spinner spins for a while then stops without going on to the next page in the process. About three hours after that, I thought I'd try with Firefox running in a 32-bit environment instead of on 64-bit Vista. So I used Ubuntu's Firefox 3.0 on 32-bit Ubuntu 9.04 in Sun VirtualBox on 64-bit Vista. This worked first time, exactly as it should, with a new version created and validated and now going out to users without complaint. \o/ Surely it's a coincidence that it worked when I switched to a 32-bit environment.
Another data point: Today was my first attempt to update my add-on since the activity in comment 24. I tried to upload a beta version, which passed validation but triggered "Oops! There seems to be a problem with this file..." It also created multiple instances of the uploaded file in the Files and Versions list. See screenshot. I'm going to delete the version with no file and see if the remaining file will become a correct beta update.
(In reply to comment #25) > I'm going to delete the version with no file and see if the remaining file will > become a correct beta update. Did so, also uploaded to release channel, both working great and going out to users ever since.
Uploaded a beta version a few moments ago and got the same "oops" error message, with two versions (one with file, one without) created, as in comment 26. I deleted the one without the file. Oops! There seems to be a problem with this file... An error occurred moving nightlaunch_0.6.20100622.beta.jar [3]. Please correct this problem and upload your file again. Today is my first attempt to upload to my add-on since the activity in comment 27.
The beta channel update in comment 28 worked great (after deleting the extra file). Also, I uploaded a release-channel update on 2010-06-29, which ran into Bug 575632. This cleared up in a few hours and is now working great.
This has been working fine for at least a couple months through six or eight releases so I'm going to mark it WORKSFORME.
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → WORKSFORME
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: