557298 - Controls Pane buttons flip from top to bottom when re-opening controls in portrait mode

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Aakash Desai [:aakashd]]

Build Id:
Mozilla/5.0 (X11; U; Linux armv7l; Nokia N900; en-US; rv:1.9.2.4pre) Gecko/20100405 Namoroka/3.6.4pre Fennec/1.1a2pre

Steps to Reproduce:
1. Open the controls pane
2. Go into portrait mode
3. In the preferences pane, click on the "Go to Page" button for the About Fennec row entry
4. Swipe to the left to open the controls sidebar
5. Click on the controls button to open the controls pane

Actual Results:
The controls pane buttons have moved from the top of the screen to the bottom

Expected Results:
The controls pane buttons should stick to one side of the screen

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: patch

We were using -moz-box-ordinal-group to flip the button box from the first item to the last item. This doesn't seem to work so well, so I tried -moz-box-direction, which just reverses the layout. This works much better. The controls stay at the bottom of the UI - where we want them.

I also fixed the button padding when in portrait mode.

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

pushed:
http://hg.mozilla.org/mobile-browser/rev/d53544385e92

Comment 3

[Aakash Desai [:aakashd]]

verified FIXED on build:
Mozilla/5.0 (X11; U; Linux armv7l; Nokia N900; en-US; rv:1.9.2.4pre) Gecko/20100406 Namoroka/3.6.4pre Fennec/1.1a2pre