Closed Bug 557355 Opened 14 years ago Closed 14 years ago

JM: Patch second guard in proto stubs for getprop

Categories

(Core :: JavaScript Engine, defect)

Product:
Core
Component:
JavaScript Engine
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: dmandelin, Unassigned)

References

Details

When we generate a stub to do a getprop from a proto (or higher up the chain), we generate 2 shape guards. When we generate another stub hanging off that one, both shape exits in the first stub should be repatched to go to the top of the new stub. Currently we only repatch the first. This isn't hurting us now in benchmarks but clearly needs fixing.
Blocks: 557358
Blocks: 557359
No longer blocks: 557358
http://hg.mozilla.org/users/danderson_mozilla.com/jaegermonkey/rev/673eac107bda

This is important for v8-deltablue with callprop PICs.
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.