557380 - TestUnicodeArguments.cpp is missing an argument to printf

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[Daniel Holbert [:dholbert]]

> ../../../mozilla/xpcom/tests/TestUnicodeArguments.cpp: In function ‘int main(int, char**)’:
> ../../../mozilla/xpcom/tests/TestUnicodeArguments.cpp:69: warning: format ‘%d’ expects type ‘int’, but argument 2 has type ‘char*’
> ../../../mozilla/xpcom/tests/TestUnicodeArguments.cpp:69: warning: too few arguments for format

Code is:
> 68   for (int i = 1; i < argc; ++i) {
> 69     printf("argv[%d] = %s; expected = %s\n", argv[i], expected_utf8[i - 1]);

Looks like we want to pass one additional argument to printf -- that argument being "i" and going right after the format string.

Comment 1

[Daniel Holbert [:dholbert]]

Attachment: fix

Comment 2

[Simon Montagu :smontagu]

Comment on attachment 437162 [details] [diff] [review]
fix

Thanks for catching this!

Comment 3

[Daniel Holbert [:dholbert]]

No prob, thanks for the quick review!

I nixed a few instances of end-of-line whitespace that I noticed in TestUnicodeArguments.cpp, too.  Pushed:
  http://hg.mozilla.org/mozilla-central/rev/bb573cd864b1