Closed Bug 557416 Opened 10 years ago Closed 10 years ago
Remove unnecessary includes and forward declarations of ns
IPres Shell and ns Pres Context
A lot of unnecessary includes and forward declarations of these two classes have accumulated throughout the tree. At the very least this wastes build time.
This patch cleans up the includes of nsIPresShell. The includes were removed by grepping for "PresShell" and if it didn't show up in the file then I removed the include. Also converted some includes in header files to use forward declarations if possible to keep includes from spreading.
Attachment #437202 - Flags: review?(roc)
Similar patch for nsPresContext. This patch depends on the nsIPresShell patch.
Attachment #437203 - Flags: review?(roc)
Attachment #437202 - Flags: review?(roc) → review+
Attachment #437203 - Flags: review?(roc) → review+
Found some build issues though I could have sworn I built with this patch. Removing checkin-needed tag so I can resolve.
Added two includes of nsIXPCScriptable.h to fix build failures.
Attachment #437748 - Flags: review?(roc) → review+
The latter patch has bitrotted.
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.3a5
Component: Layout: Misc Code → Layout
Product: Core Graveyard → Core
You need to log in before you can comment on or make changes to this bug.