Closed
Bug 557416
Opened 15 years ago
Closed 15 years ago
Remove unnecessary includes and forward declarations of nsIPresShell and nsPresContext
Categories
(Core :: Layout, defect)
Core
Layout
Tracking
()
RESOLVED
FIXED
mozilla1.9.3a5
People
(Reporter: craig.topper, Assigned: craig.topper)
References
Details
Attachments
(2 files, 2 obsolete files)
|
44.54 KB,
patch
|
roc
:
review+
|
Details | Diff | Splinter Review |
|
71.72 KB,
patch
|
Details | Diff | Splinter Review |
A lot of unnecessary includes and forward declarations of these two classes have accumulated throughout the tree. At the very least this wastes build time.
|
Assignee | |
Comment 1•15 years ago
|
||
This patch cleans up the includes of nsIPresShell. The includes were removed by grepping for "PresShell" and if it didn't show up in the file then I removed the include.
Also converted some includes in header files to use forward declarations if possible to keep includes from spreading.
Attachment #437202 -
Flags: review?(roc)
|
|
Assignee | |
Comment 2•15 years ago
|
||
Similar patch for nsPresContext. This patch depends on the nsIPresShell patch.
Attachment #437203 -
Flags: review?(roc)
Attachment #437202 -
Flags: review?(roc) → review+
Attachment #437203 -
Flags: review?(roc) → review+
|
|
Assignee | |
Updated•15 years ago
|
Keywords: checkin-needed
|
|
Assignee | |
Comment 3•15 years ago
|
||
Found some build issues though I could have sworn I built with this patch. Removing checkin-needed tag so I can resolve.
Keywords: checkin-needed
|
|
Assignee | |
Comment 4•15 years ago
|
||
Added two includes of nsIXPCScriptable.h to fix build failures.
Attachment #437203 -
Attachment is obsolete: true
Attachment #437748 -
Flags: review?(roc)
Attachment #437748 -
Flags: review?(roc) → review+
|
|
Assignee | |
Updated•15 years ago
|
Keywords: checkin-needed
The latter patch has bitrotted.
|
|
Assignee | |
Comment 6•15 years ago
|
||
Attachment #437748 -
Attachment is obsolete: true
http://hg.mozilla.org/mozilla-central/rev/f219b151fc4a
http://hg.mozilla.org/mozilla-central/rev/7d2746bc7471
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.3a5
|
||
Updated•7 years ago
|
Product: Core → Core Graveyard
|
||
Updated•7 years ago
|
Component: Layout: Misc Code → Layout
Product: Core Graveyard → Core
You need to log in
before you can comment on or make changes to this bug.
Description
•