Closed
Bug 557470
Opened 14 years ago
Closed 14 years ago
make check in xpcom/tests/ is not portable on Solaris
Categories
(Firefox Build System :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: ginnchen+exoracle, Assigned: ginnchen+exoracle)
Details
Attachments
(1 file)
|
1.06 KB,
patch
|
ted
:
review+
|
Details | Diff | Splinter Review |
Solaris grep doesn't have "-q" option Also, it seems Solaris sh doesn't like if $$( grep ...
Assignee: nobody → ginn.chen
Status: NEW → ASSIGNED
Attachment #437262 -
Flags: review?(ted.mielczarek)
|
||
Comment 2•14 years ago
|
||
Comment on attachment 437262 [details] [diff] [review] patch >diff --git a/xpcom/tests/Makefile.in b/xpcom/tests/Makefile.in >--- a/xpcom/tests/Makefile.in >+++ b/xpcom/tests/Makefile.in >@@ -201,21 +201,21 @@ else > DIST_PATH = $(DIST)/bin/ > RM_DIST = rm -f > regOrderDir="$(call getnativepath,$(abs_srcdir)/regorder)"; > DOCOPY= > endif > check:: > @echo "Running XPIDL tests" > $(XPIDL_COMPILE) -m header $(srcdir)/TestScriptable.idl >- @if grep Notscriptable TestScriptable.h | grep -q NS_SCRIPTABLE ; then \ >+ @if grep Notscriptable TestScriptable.h | grep NS_SCRIPTABLE 2>/dev/null ; then \ I think you want "grep NS_SCRIPTABLE >/dev/null 2>&1", right? Otherwise you'll still get the results of the grep to stdout.
Attachment #437262 -
Flags: review?(ted.mielczarek) → review+
http://hg.mozilla.org/mozilla-central/rev/e641320b77b4
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
|
||
Updated•6 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•