557491 - [autoconfig] emailAddress param not sent to autoconfig server

Status: RESOLVED FIXED

(Thunderbird :: Account Manager, defect, P1)

Description

[Ben Bucksch (:BenB)]

<https://developer.mozilla.org/en/Thunderbird/Autoconfiguration#Configuration_server_at_ISP>

We query <http://autoconfig.example.com/mail/config-v1.xml> instead of <http://autoconfig.example.com/mail/config-v1.1.xml?emailAddress=[e-mail]>. The lack of email address prevents the ISP to adjust the config, esp. the username, to the user, which is part of the point of the autoconfig server at the ISP.

Comment 1

[Ben Bucksch (:BenB)]

Attachment: Fix, v1

Comment 2

[Juho-Pekka Kuitunen]

The emailAddress parameter is critical for a situation where the username has no direct link to the email address.

e.g. email address is [e-mail] but username could be 'juhokuit'.

If the parameter is given we can make a simple lookup to get the username from e.g. DB or LDAP.

Comment 3

[Blake Winton (:bwinton) (:☕️)]

Comment on attachment 437281 [details] [diff] [review]
Fix, v1

I would love it if you could add a test, but it seems like a win to me even without the test.

(Also, are you _sure_ you don't need parentheses around the "url.indexOf("?") == -1" part?  Would you mind adding them, just to make me feel better?  ;)

Thanks,
Blake.

Comment 4

[Ben Bucksch (:BenB)]

Test build for Juho-Pekka:
http://s3.mozillamessaging.com/build/try-server/2010-04-17_14:[e-mail]-autoconfig-with-emailaddress/[e-mail]
http://s3.mozillamessaging.com/build/try-server/2010-04-17_14:[e-mail]-autoconfig-with-emailaddress/[e-mail]2
http://s3.mozillamessaging.com/build/try-server/2010-04-17_14:[e-mail]-autoconfig-with-emailaddress/[e-mail]

Comment 5

[Ben Bucksch (:BenB)]

> (Also, are you _sure_ you don't need parentheses around the "url.indexOf("?")
> == -1" part?

Yes.
<https://developer.mozilla.org/en/Core_JavaScript_1.5_Reference/Operators/Operator_Precedence>
== has higher precedence than ?:
?: has one of the lowest precedences of all, only higher than = assignment and comma

Comment 6

[Blake Winton (:bwinton) (:☕️)]

(Psst, you've got an r+, you can just check it in, instead of doing a try-server build.  ;)

Later,
Blake.

Comment 7

[Ben Bucksch (:BenB)]

*snicker*, yeah, noticed when I made the comment...
I'm about to check in once the tree goes green.

Comment 8

[Ben Bucksch (:BenB)]

Commited as <http://hg.mozilla.org/comm-central/rev/2f484966ab84>

FIXED