add fn boundary pseudo-ops to nsprpub/pr/src/md/unix/os_Linux_x86_64.s

RESOLVED FIXED in 4.8.5

Status

NSPR
NSPR
P2
normal
RESOLVED FIXED
8 years ago
8 years ago

People

(Reporter: jseward, Assigned: jseward)

Tracking

other
4.8.5
x86_64
Linux

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

8 years ago
The assembly routines in os_Linux_x86_64.s are not properly delineated
with .type and .size pseudo-ops, as normal g++ generated functions
are.  This means their names don't show up in backtraces, at least
those created by Valgrind (haven't tried GDB).  This is of
(peripheral) relevance for bug 551155.
(Assignee)

Comment 1

8 years ago
Created attachment 437284 [details] [diff] [review]
proposed fix (checked in)
Assignee: nobody → jseward
(Assignee)

Comment 2

8 years ago
Not sure how set Product to NSPR.  When I do that I get asked
a bunch of questions about versions, that I don't know the 
answer to.
Hardware: x86 → x86_64

Updated

8 years ago
Component: General → NSPR
Product: Core → NSPR
QA Contact: general → nspr
Version: Trunk → other
(Assignee)

Updated

8 years ago
Attachment #437284 - Flags: review?(wtc)

Updated

8 years ago
Status: NEW → ASSIGNED
Target Milestone: --- → 4.8.5
Bug 557501 - add fn boundary pseudo-ops 
Patch contributed by Julian Seward <jseward@acm.org>, r=wtc

Checking in pr/src/md/unix/os_Linux_x86_64.s; new revision: 1.4; previous: 1.3

I'll keep this open until the question in comment 3 is answered.
Priority: -- → P2
Attachment #437284 - Attachment description: proposed fix → proposed fix (checked in)

Updated

8 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.