The assembly routines in os_Linux_x86_64.s are not properly delineated with .type and .size pseudo-ops, as normal g++ generated functions are. This means their names don't show up in backtraces, at least those created by Valgrind (haven't tried GDB). This is of (peripheral) relevance for bug 551155.
Created attachment 437284 [details] [diff] [review] proposed fix (checked in)
Assignee: nobody → jseward
Not sure how set Product to NSPR. When I do that I get asked a bunch of questions about versions, that I don't know the answer to.
Hardware: x86 → x86_64
Component: General → NSPR
Product: Core → NSPR
QA Contact: general → nspr
Version: Trunk → other
Comment on attachment 437284 [details] [diff] [review] proposed fix (checked in) r=wtc. Thanks for the patch. Do http://mxr.mozilla.org/nspr/source/nsprpub/pr/src/md/unix/os_Linux_x86.s http://mxr.mozilla.org/nspr/source/nsprpub/pr/src/md/unix/os_Darwin_x86.s http://mxr.mozilla.org/nspr/source/nsprpub/pr/src/md/unix/os_Darwin_x86_64.s http://mxr.mozilla.org/nspr/source/nsprpub/pr/src/md/unix/os_SunOS_x86.s http://mxr.mozilla.org/nspr/source/nsprpub/pr/src/md/unix/os_SunOS_x86_64.s etc. need the same fix?
Attachment #437284 - Flags: review?(wtc) → review+
Bug 557501 - add fn boundary pseudo-ops Patch contributed by Julian Seward <email@example.com>, r=wtc Checking in pr/src/md/unix/os_Linux_x86_64.s; new revision: 1.4; previous: 1.3 I'll keep this open until the question in comment 3 is answered.
Priority: -- → P2
Attachment #437284 - Attachment description: proposed fix → proposed fix (checked in)
Status: ASSIGNED → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.