Closed
Bug 557501
Opened 14 years ago
Closed 14 years ago
add fn boundary pseudo-ops to nsprpub/pr/src/md/unix/os_Linux_x86_64.s
Categories
(NSPR :: NSPR, defect, P2)
Tracking
(Not tracked)
RESOLVED
FIXED
4.8.5
People
(Reporter: jseward, Assigned: jseward)
Details
Attachments
(1 file)
|
2.00 KB,
patch
|
wtc
:
review+
|
Details | Diff | Splinter Review |
The assembly routines in os_Linux_x86_64.s are not properly delineated with .type and .size pseudo-ops, as normal g++ generated functions are. This means their names don't show up in backtraces, at least those created by Valgrind (haven't tried GDB). This is of (peripheral) relevance for bug 551155.
|
Assignee | |
Comment 1•14 years ago
|
||
Assignee: nobody → jseward
|
|
Assignee | |
Comment 2•14 years ago
|
||
Not sure how set Product to NSPR. When I do that I get asked a bunch of questions about versions, that I don't know the answer to.
Hardware: x86 → x86_64
|
||
Updated•14 years ago
|
Component: General → NSPR
Product: Core → NSPR
QA Contact: general → nspr
Version: Trunk → other
|
|
Assignee | |
Updated•14 years ago
|
Attachment #437284 -
Flags: review?(wtc)
|
||
Comment 3•14 years ago
|
||
Comment on attachment 437284 [details] [diff] [review] proposed fix (checked in) r=wtc. Thanks for the patch. Do http://mxr.mozilla.org/nspr/source/nsprpub/pr/src/md/unix/os_Linux_x86.s http://mxr.mozilla.org/nspr/source/nsprpub/pr/src/md/unix/os_Darwin_x86.s http://mxr.mozilla.org/nspr/source/nsprpub/pr/src/md/unix/os_Darwin_x86_64.s http://mxr.mozilla.org/nspr/source/nsprpub/pr/src/md/unix/os_SunOS_x86.s http://mxr.mozilla.org/nspr/source/nsprpub/pr/src/md/unix/os_SunOS_x86_64.s etc. need the same fix?
Attachment #437284 -
Flags: review?(wtc) → review+
|
|
||
Updated•14 years ago
|
Status: NEW → ASSIGNED
Target Milestone: --- → 4.8.5
|
||
Comment 4•14 years ago
|
||
Bug 557501 - add fn boundary pseudo-ops Patch contributed by Julian Seward <jseward@acm.org>, r=wtc Checking in pr/src/md/unix/os_Linux_x86_64.s; new revision: 1.4; previous: 1.3 I'll keep this open until the question in comment 3 is answered.
Priority: -- → P2
|
|
||
Updated•14 years ago
|
Attachment #437284 -
Attachment description: proposed fix → proposed fix (checked in)
|
|
||
Updated•14 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•