nsDebugImpl.cpp: "warning: enumeration value ‘NS_ASSERT_UNINITIALIZED’ not handled in switch"

RESOLVED FIXED

Status

()

Core
XPCOM
RESOLVED FIXED
8 years ago
8 years ago

People

(Reporter: dholbert, Assigned: dholbert)

Tracking

Trunk
x86
Linux
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [build_warning])

Attachments

(1 attachment, 1 obsolete attachment)

805 bytes, patch
Benjamin Smedberg
: review+
Details | Diff | Splinter Review
(Assignee)

Description

8 years ago
Filing bug for this build warning (the only warning for the "xpcom/base/" directory):
{
> xpcom/base/nsDebugImpl.cpp: In function ‘void NS_DebugBreak_P(PRUint32, const char*, const char*, const char*, PRInt32)’:
> xpcom/base/nsDebugImpl.cpp:334: warning: enumeration value ‘NS_ASSERT_UNINITIALIZED’ not handled in switch
}
(Assignee)

Comment 1

8 years ago
Created attachment 437342 [details] [diff] [review]
fix
Attachment #437342 - Flags: review?
(Assignee)

Updated

8 years ago
Attachment #437342 - Flags: review? → review?(benjamin)

Comment 2

8 years ago
Comment on attachment 437342 [details] [diff] [review]
fix

We should default to trap if there is nothing else set.
Attachment #437342 - Flags: review?(benjamin) → review-
(Assignee)

Comment 3

8 years ago
Created attachment 437894 [details] [diff] [review]
fix v2

Ok -- this version groups "NS_ASSERT_UNINITIALIZED" to fall into the "TRAP" case.

Adds a return statement, too, for consistency & foolproofness-against-future-case-statement-rearranging.
Attachment #437342 - Attachment is obsolete: true
Attachment #437894 - Flags: review?
(Assignee)

Updated

8 years ago
Attachment #437894 - Flags: review? → review?(benjamin)

Updated

8 years ago
Attachment #437894 - Flags: review?(benjamin) → review+
(Assignee)

Comment 4

8 years ago
http://hg.mozilla.org/mozilla-central/rev/ed68058029e3
Status: ASSIGNED → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
(Assignee)

Updated

8 years ago
Whiteboard: [build_warning]
You need to log in before you can comment on or make changes to this bug.