Closed Bug 557567 Opened 10 years ago Closed 10 years ago

urlbar changes when pages load within frames

Categories

(Firefox for Android Graveyard :: General, defect, minor)

x86
Linux
defect
Not set
minor

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: mbrubeck, Assigned: mbrubeck)

References

()

Details

Attachments

(1 file)

Steps to reproduce:
1. Open http://zvon.org/other/haskell/Outputglobal/index.html
2. Click any link in the left frame (e.g. "Functions")

Actual Results:
The urlbar changes to show the URI instead of the title.

Expected Results:
urlbar contents do not change.
Attached patch patchSplinter Review
With this patch, we ignore onLocationChange events in child frames.  (This is exactly what we were already doing for onStateChange events.)
Assignee: nobody → mbrubeck
Status: NEW → ASSIGNED
Attachment #437346 - Flags: review?(mark.finkle)
Comment on attachment 437346 [details] [diff] [review]
patch

Looks good to me, but I want Ben to have a look too.
Attachment #437346 - Flags: review?(webapps)
Attachment #437346 - Flags: review?(mark.finkle)
Attachment #437346 - Flags: review+
Attachment #437346 - Flags: review?(webapps) → review+
pushed:
http://hg.mozilla.org/mobile-browser/rev/8ea72fbe42d6
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
verified FIXED On builds:

Mozilla/5.0 (X11; U; Linux armv7l; Nokia N900; en-US; rv:1.9.2.4pre) Gecko/20100412 Namoroka/3.6.4pre Fennec/1.1a2pre

and

Mozilla/5.0 (X11; U; Linux armv6l; en-US; rv:1.9.3a4pre) Gecko/20100412 Namoroka/3.7a4pre Fennec/1.1a2pre
Status: RESOLVED → VERIFIED
Flags: in-litmus?
Assignee: mbrubeck → aaron.train
This should become an FFT litmus testcase.
Assignee: aaron.train → mbrubeck
Flags: in-litmus? → in-litmus?(aaron.train)
(In reply to comment #5)
> This should become an FFT litmus testcase.

https://litmus.mozilla.org/show_test.cgi?searchType=by_id&id=13626
Flags: in-litmus?(aaron.train) → in-litmus+
You need to log in before you can comment on or make changes to this bug.