557567 - urlbar changes when pages load within frames

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Matt Brubeck (:mbrubeck)]

Steps to reproduce:
1. Open http://zvon.org/other/haskell/Outputglobal/index.html
2. Click any link in the left frame (e.g. "Functions")

Actual Results:
The urlbar changes to show the URI instead of the title.

Expected Results:
urlbar contents do not change.

Comment 1

[Matt Brubeck (:mbrubeck)]

Attachment: patch

With this patch, we ignore onLocationChange events in child frames.  (This is exactly what we were already doing for onStateChange events.)

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 437346 [details] [diff] [review]
patch

Looks good to me, but I want Ben to have a look too.

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

pushed:
http://hg.mozilla.org/mobile-browser/rev/8ea72fbe42d6

Comment 4

[Aakash Desai [:aakashd]]

verified FIXED On builds:

Mozilla/5.0 (X11; U; Linux armv7l; Nokia N900; en-US; rv:1.9.2.4pre) Gecko/20100412 Namoroka/3.6.4pre Fennec/1.1a2pre

and

Mozilla/5.0 (X11; U; Linux armv6l; en-US; rv:1.9.3a4pre) Gecko/20100412 Namoroka/3.7a4pre Fennec/1.1a2pre

Comment 5

[Martijn Wargers (dead)]

This should become an FFT litmus testcase.

Comment 6

[Aaron Train [:aaronmt]]

(In reply to comment #5)
> This should become an FFT litmus testcase.

https://litmus.mozilla.org/show_test.cgi?searchType=by_id&id=13626