Closed Bug 557625 Opened 14 years ago Closed 14 years ago

Hook up POP3 to msgAsyncPrompt service and make its password prompts serial again

Categories

(MailNews Core :: Networking: POP, defect)

defect
Not set
normal

Tracking

(blocking-thunderbird3.1 beta2+, thunderbird3.1 beta2-fixed)

RESOLVED FIXED
Thunderbird 3.1b2
Tracking Status
blocking-thunderbird3.1 --- beta2+
thunderbird3.1 --- beta2-fixed

People

(Reporter: standard8, Assigned: standard8)

References

Details

Attachments

(1 file, 2 obsolete files)

Spinning out the separate work from bug 338549. We need to hook up POP3 to the msgAsyncPrompt service so that the prompts will occur in serial fashion.

Attachment 405043 [details] [diff] has an incomplete first version for this bug.
Attached patch WIP Patch (obsolete) — Splinter Review
Work in progress - updated version of the attachment on bug 338549.

Still have various issues to contend with including the code in send password/username and exit options in OnPromptStart.
Whiteboard: [eta patch for review Thurs 8th]
Attached patch The fix (obsolete) — Splinter Review
Ok, I think this does all the necessary. It may be a bit raw still, I'm going to do a bit more testing in a while, but wanted to get this initial version up for you to start looking at.

The unit tests pass and the best testing I've had to check the serial prompts is by having two 3 pane windows open on different accounts, and doing a get mail on each of them.
Attachment #437405 - Attachment is obsolete: true
Attachment #440282 - Flags: superreview?(bienvenu)
Attachment #440282 - Flags: review?(bienvenu)
Whiteboard: [eta patch for review Thurs 8th] → [has initial patch for review]
Canceling the pop3 password prompt brings up a dialog "error getting password", which it shouldn't. I think you need to propagate the fact that the user pressed cancel, like I had to do for IMAP.

I tried bad passwords, and the "enter new password" stuff worked...

logging instead of printf would be good here:

-  PR_LOG(POP3LOGMODULE, PR_LOG_MAX, ("GetPassword()"));
-  nsresult rv = NS_OK;
+  printf("current state %d\n", m_pop3ConData->next_state);
+  switch (m_pop3ConData->next_state)
Comment on attachment 440282 [details] [diff] [review]
The fix

minusing based on cancel issue.
Attachment #440282 - Flags: superreview?(bienvenu)
Attachment #440282 - Flags: superreview-
Attachment #440282 - Flags: review?(bienvenu)
Attachment #440282 - Flags: review-
Attached patch The fix v2Splinter Review
Ok, I'd missed handling that cancel case, I've added a check now so the connection will just abort if the user hits cancel (like it used to).
Attachment #440282 - Attachment is obsolete: true
Attachment #440368 - Flags: superreview?(bienvenu)
Attachment #440368 - Flags: review?(bienvenu)
this works better, definitely.
Attachment #440368 - Flags: superreview?(bienvenu)
Attachment #440368 - Flags: superreview+
Attachment #440368 - Flags: review?(bienvenu)
Attachment #440368 - Flags: review+
Checked in: http://hg.mozilla.org/comm-central/rev/2fb73ad3a589
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Whiteboard: [has initial patch for review]
Target Milestone: --- → Thunderbird 3.1b2
You need to log in before you can comment on or make changes to this bug.