557757 - e10s builds are burning after merge with mozilla-central

Status: RESOLVED FIXED

(Core :: IPC, defect)

Description

[Oleg Romashin (:romaxa)]

Build bustage after merge with m-c, caused by not synced js/ipc code with bug 548702.

Also possible problem with nsDOMClassInfoClasses.h and bug 533637 might cause some problems with ContentFrameMessageManager class

Comment 1

[Oleg Romashin (:romaxa)]

Attachment: Trivial JS compilation fix

Comment 2

[Oleg Romashin (:romaxa)]

Also ContentFrameMessageManager not compiling and showing this error:

../../staticlib/components/libgklayout.a(nsDOMClassInfo.o): In function `nsDOMClassInfo::Init()':
dom/base/nsDOMClassInfo.cpp:3765: undefined reference to `kDOMClassInfo_ContentFrameMessageManager_interfaces'
/usr/bin/ld: ../../staticlib/components/libgklayout.a(nsDOMClassInfo.o): relocation R_386_GOTOFF against undefined hidden symbol `kDOMClassInfo_ContentFrameMessageManager_interfaces' can not be used when making a shared object
/usr/bin/ld: final link failed: Bad value
collect2: ld returned 1 exit status
make[5]: *** [libxul.so] Error 1


Not sure if this fix was good or bad
http://hg.mozilla.org/projects/electrolysis/rev/2e96ee8bf80d

Comment 3

[Oleg Romashin (:romaxa)]

Attachment: Build fix for FrameMessenger

This patch compiles fine for me

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 437514 [details] [diff] [review]
Build fix for FrameMessenger

So apparently this should be done for TabChildGlobal

Comment 5

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 437513 [details] [diff] [review]
Trivial JS compilation fix

I guess this is right.

Comment 6

[Olli Pettay [:smaug][[e-mail]]]

Attachment: based on peterv's comment, this should work

Comment 7

[Olli Pettay [:smaug][[e-mail]]]

Pushed the following changesets
http://hg.mozilla.org/projects/electrolysis/rev/ac377f2167c0
http://hg.mozilla.org/projects/electrolysis/rev/c23610cf63c9

Comment 8

[Oleg Romashin (:romaxa)]

Fixed