557850 - Test Pilot UI: XUL window does not auto refresh

Status: VERIFIED FIXED

(Mozilla Labs Graveyard :: Test Pilot, defect)

Description

[Jono Xia]

If you leave the XUL window open, it can end up displaying out-of-date and inaccurate information, because it never updates except when it is first opened.  It should either have a timer to periodically refresh, or it should register observers for task state changes.

Comment 1

[Jono Xia]

Note that whenever a task has its status changed, it fires a notification through the Observers module ("testpilot:task:changed"), unless suppressNotification is set to true.  See the code in tasks.js in function changeStatus().  The XUL window could probably register an observer for this notification to find out when a task is changing state, and move the task to the appropriate list in response.

Comment 2

[Raymond Lee [:raymondlee]]

Attachment: Patch for this bug

To make it simple, I've added an observer and reload all lists when a task is changing its state.

Comment 3

[Jono Xia]

Submitting a study through the XUL window feels a little disconcerting now, as it seems to just disappear; I think users will wonder where it went.  Maybe we could display "thanks for submitting" for a second or two and then do some sort of fade-out or slide-away animation?  Something that implies it has moved to the "finished studies" tab?

Anyway the original bug is fixed and this is more of a design question, so I'm going to close this bug and open a new one.

Comment 4

[Jono Xia]

Requesting a litmus test: Submit a study from the "All your studies" window interface, verify that it immediately moves to the "finished studies" tab.

Comment 5

[Tracy Walker [:tracy]]

Verified with a4 on 3.6.4

Comment 6

[Tracy Walker [:tracy]]

This is covered in various existing Litmus test cases.