557861 - Registration hashes passwords with exec() and hardcoded slappasswd path

Status: RESOLVED FIXED

(Cloud Services Graveyard :: Server: Sync, defect)

Description

[Les Orchard [:lorchard]]

In setting up the weave-registration stack on my laptop, I noticed that the mozilla auth driver is shelling out to run slapppasswd to generate {SSHA} passwords.  

I have a hunch that this might not scale well - and the path to slappasswd is hardcoded, which made it hard to run on my laptop.

This can be done full within PHP.

Comment 1

[Les Orchard [:lorchard]]

Attachment: patch to generate {ssha} hashed passwords in PHP

Comment 2

[Toby Elliott [:telliott]]

Comment on attachment 437616 [details] [diff] [review]
patch to generate {ssha} hashed passwords in PHP

Looks good, even the vim comment :)

Comment 3

[Les Orchard [:lorchard]]

https://hg.mozilla.org/labs/weaveserver-registration/rev/544cfa94c8e1