557910 - disable 32bit build testing on snow leopard

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[alice nodelman [:alice] [:anode]]

Per irc discussion with shaver.  We may want this ability in future, but it is of a higher priority to get 64 bit builds tested on 64 bit platforms - so we'll disable this for now and turn it back on once we have appropriate support in the graph server to differentiate between these two types of builds.

This bug should cover disabling the tests themselves along with updating the graph server in some way to mark the old tests as having been done with 32 bit builds.

Comment 1

[alice nodelman [:alice] [:anode]]

Attachment: don't test 32bit mac builds on 64bit mac slaves

Comment 2

[Mike Shaver (:shaver -- probably not reading bugmail closely)]

Sounds great!  I think just deleting the old graph server rows would actually be fine.

Comment 3

[alice nodelman [:alice] [:anode]]

For reals?  I'm off to go write a big old remove statement!

Comment 4

[alice nodelman [:alice] [:anode]]

Proposed removal of 32bit build on 64bit platform test results:

delete from rest_run_values where exists (select test_runs.id from test_run_values, test_runs, machines where test_runs.id = test_run_values.test_run_id and  test_runs.machine_id = machines.id and machines.name like "%talos-r3-snow%";);

delete form test_runs where exists (select test_runs.id from test_runs, machines where test_runs.machine_id = machines.id and machines.name like "%talos-r3-snow%");

Comment 5

[alice nodelman [:alice] [:anode]]

Attachment: don't test 32bit mac builds on 64bit mac slaves (take 2)

Based on irc feedback from catlee.

Comment 6

[Chris AtLee [:catlee]]

Comment on attachment 437684 [details] [diff] [review]
don't test 32bit mac builds on 64bit mac slaves (take 2)

>                 PLATFORMS['linux64']['slave_platforms'] + \
>                 PLATFORMS['win32']['slave_platforms'] + \
>                 PLATFORMS['macosx']['slave_platforms']
>+                PLATFORMS['macosx64']['slave_platforms']

You need a '+ \' on the previous line

> 
> BRANCH_UNITTEST_VARS = {
>     'hghost': 'hg.mozilla.org',
>@@ -213,12 +218,16 @@
>         "http://ftp.mozilla.org/pub/mozilla.org/firefox/tinderbox-builds/bm-xserve08-mozilla1.9.0/",
>         "http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/latest-mozilla1.9.0/",
>         ],
>+    'macosx64': [
>+        ""
>+        ],

I think it's safer to set this to [], instead of [""].

Comment 7

[alice nodelman [:alice] [:anode]]

Attachment: [checked in]don't test 32bit mac builds on 64bit mac slaves (take 3)

Also includes talos-staging-pool update (some macosx64 changes were already accidentally checked in there, this just repairs them).

Comment 8

[alice nodelman [:alice] [:anode]]

Attachment: sql for removing 32-on-64 testing results

Comment 9

[Chris AtLee [:catlee]]

Comment on attachment 437691 [details]
sql for removing 32-on-64 testing results

>delete from test_run_values where exists (select test_runs.id from test_run_values, test_runs, machines where test_runs.id = test_run_values.test_run_id and  test_runs.machine_id = machines.id and machines.name like "%talos-r3-snow%";);

I'm pretty sure this will end up deleting all rows in test_run_values.  At least, 'select * from test_run_values where exists (...)' selects all 160 million rows in the production db.


>delete form test_runs where exists (select test_runs.id from test_runs, machines where test_runs.machine_id = machines.id and machines.name like "%talos-r3-snow%");

Same issue.

Also, strings need to be single quoted.

Comment 10

[alice nodelman [:alice] [:anode]]

Comment on attachment 437690 [details] [diff] [review]
[checked in]don't test 32bit mac builds on 64bit mac slaves (take 3)

changeset:   2295:a5946519dc4a

Comment 11

[alice nodelman [:alice] [:anode]]

No longer doing any testing on snow leopard till graph server is repaired.

Applied patch to staging/production and reconfig-ed.  Will require another reconfig to turn on 64-on-64 testing.

Comment 12

[alice nodelman [:alice] [:anode]]

Attachment: sql for removing 32-on-64 testing results (take 2)

That 'exists' stuff wasn't working right.  This solution is a lot simpler and doesn't remove the entire test_runs/test_run_values tables.

Comment 13

[Chris AtLee [:catlee]]

Comment on attachment 437963 [details]
sql for removing 32-on-64 testing results (take 2)

First query matches 563635 rows in my test of an older production snapshot, and the second one matches 18718 rows.  A brief inspection of some of the matched rows looks good.

Comment 14

[alice nodelman [:alice] [:anode]]

Attachment: sql for removing 32-on-64 testing results (take 3)

Same as before, but uses a temporary table with foreign key constraints to make it run faster.

I ran this on stage and it looks like all the snow leopard data is gone.

Comment 15

[alice nodelman [:alice] [:anode]]

Snow leopard up and reporting, testing 64bit macosx builds only.