Closed Bug 557991 Opened 11 years ago Closed 11 years ago

nanojit: remove dead code from CodeAlloc

Categories

(Core Graveyard :: Nanojit, defect)

x86
macOS
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: n.nethercote, Assigned: n.nethercote)

References

Details

(Whiteboard: fixed-in-nanojit, fixed-in-tracemonkey, fixed-in-tamarin)

Attachments

(1 file)

Attached patch patchSplinter Review
There's a lot of dead code in CodeAlloc.  After removing it there was only one remaining call to containsPtr() and it is a simple function so I just inlined the call and removed the function as well.

I checked the patch on TM as well to make sure all these functions were dead in it too.

This blocks bug 506693 because that bug also modifies CodeAlloc, and removing this dead code means that fewer changes are needed there.
Attachment #437760 - Flags: review?(edwsmith)
Comment on attachment 437760 [details] [diff] [review]
patch

Leftovers from an experimental jit-cache, fine to remove.
Attachment #437760 - Flags: review?(edwsmith) → review+
http://hg.mozilla.org/tracemonkey/rev/e53cd9b17fed
Whiteboard: fixed-in-nanojit → fixed-in-nanojit, fixed-in-tracemonkey
TR: http://hg.mozilla.org/tamarin-redux/rev/5afbcf4dc0ae
Whiteboard: fixed-in-nanojit, fixed-in-tracemonkey → fixed-in-nanojit, fixed-in-tracemonkey, fixed-in-tamarin
http://hg.mozilla.org/mozilla-central/rev/e53cd9b17fed
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.