nanojit: remove dead code from CodeAlloc

RESOLVED FIXED

Status

Core Graveyard
Nanojit
RESOLVED FIXED
8 years ago
4 years ago

People

(Reporter: njn, Assigned: njn)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: fixed-in-nanojit, fixed-in-tracemonkey, fixed-in-tamarin)

Attachments

(1 attachment)

(Assignee)

Description

8 years ago
Created attachment 437760 [details] [diff] [review]
patch

There's a lot of dead code in CodeAlloc.  After removing it there was only one remaining call to containsPtr() and it is a simple function so I just inlined the call and removed the function as well.

I checked the patch on TM as well to make sure all these functions were dead in it too.

This blocks bug 506693 because that bug also modifies CodeAlloc, and removing this dead code means that fewer changes are needed there.
Attachment #437760 - Flags: review?(edwsmith)

Comment 1

8 years ago
Comment on attachment 437760 [details] [diff] [review]
patch

Leftovers from an experimental jit-cache, fine to remove.
Attachment #437760 - Flags: review?(edwsmith) → review+
(Assignee)

Comment 2

8 years ago
http://hg.mozilla.org/projects/nanojit-central/rev/335ca0fff2a7
Whiteboard: fixed-in-nanojit
(Assignee)

Comment 3

7 years ago
http://hg.mozilla.org/tracemonkey/rev/e53cd9b17fed
Whiteboard: fixed-in-nanojit → fixed-in-nanojit, fixed-in-tracemonkey

Comment 4

7 years ago
TR: http://hg.mozilla.org/tamarin-redux/rev/5afbcf4dc0ae
Whiteboard: fixed-in-nanojit, fixed-in-tracemonkey → fixed-in-nanojit, fixed-in-tracemonkey, fixed-in-tamarin

Comment 5

7 years ago
http://hg.mozilla.org/mozilla-central/rev/e53cd9b17fed
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
Component: Nanojit → Nanojit
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.