[compare-locales] compare-dirs should support l10n-merge

RESOLVED FIXED

Status

Mozilla Localizations
Infrastructure
RESOLVED FIXED
8 years ago
8 years ago

People

(Reporter: Pike, Assigned: Pike)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

8 years ago
I expect weave to use compare-dirs instead of compare-locales, need to add an option to that so that it supports l10n-merge, too.
(Assignee)

Comment 1

8 years ago
Created attachment 437874 [details] [diff] [review]
add l10n-merge to compare-dirs, error on missing strings without merge

This is a patch that I'd like to have on the production tag, too, so that weave can use the same code as the rest of release.

It's adding the -m option to compare-dirs, passing it down to the worker code the very same way that compare-locales does.
I made File switch the default value of module from None to '', as the latter is fine as an argument to os.path.join(base, module, path). The default value path is not executed as part of compare-locales, but just as part of compare-dirs, so this patch is still pretty much NPOTB.

I copied the return value logic from compare-locales as well, works as expected.
Assignee: nobody → l10n
Status: NEW → ASSIGNED
Attachment #437874 - Flags: review?(ccooper)

Updated

8 years ago
Attachment #437874 - Flags: review?(ccooper) → review+

Comment 2

8 years ago
Comment on attachment 437874 [details] [diff] [review]
add l10n-merge to compare-dirs, error on missing strings without merge

Looks good.

Updated

8 years ago
Blocks: 557311

Updated

8 years ago
No longer blocks: 557311
(Assignee)

Comment 3

8 years ago
Marking FIXED.
Status: ASSIGNED → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.