558087 - avoid non-pixel-aligned clips for mobile's Image Layer composite

Status: NEW

(Core :: Graphics, defect)

Description

[Oleg Romashin (:romaxa)]

Attachment: snap to pixels more aggressively for mobile

Currently we are painting BasicLayers with PixelSnappedRectangleAndSetPattern
http://mxr.mozilla.org/mozilla-central/source/gfx/layers/basic/BasicLayers.cpp#360

And it cause slow composition for scaled layer.

Idea is to make fix for PixelSnappedRectangleAndSetPattern similar to bug
https://bugzilla.mozilla.org/show_bug.cgi?id=459150

Comment 1

[Oleg Romashin (:romaxa)]

This is making video layer composition 2x faster.

Comment 2

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Comment on attachment 437860 [details] [diff] [review]
 snap to pixels more aggressively for mobile

bouncing over to roc -- he's the snapmaster

Comment 3

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Why don't we just do this for all configurations? I think that would be fine.

Comment 4

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 437860 [details] [diff] [review]
 snap to pixels more aggressively for mobile

>+    if (UserToDevicePixelSnapped(r), PR_TRUE) {

do you perhaps mean?

>+    if (UserToDevicePixelSnapped(r, PR_TRUE)) {

Comment 5

[Oleg Romashin (:romaxa)]

Attachment: Snap to pixels by default

Comment 6

[Oleg Romashin (:romaxa)]

> do you perhaps mean?
> 
> >+    if (UserToDevicePixelSnapped(r, PR_TRUE)) {

Oh, yep.
I have sent BUG558087 try-request for test

Comment 7

[Oleg Romashin (:romaxa)]

Attachment: Snap everything

Comment 8

[Oleg Romashin (:romaxa)]

Sent try server build for last patch
"BUG558087-2"

Comment 9

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Sorry, I misunderstood you on IRC.

I don't think we should change the default parameter for gfxContext::Rectangle.

I think we should take your original patch, but for all platforms, so that when gfxContext::Rectangle is snapping to pixels, we allow snapping even if there's a scale factor in the transform.

Comment 10

[Oleg Romashin (:romaxa)]

Comment on attachment 437958 [details] [diff] [review]
Snap everything 

Then I think second patch should be fine

Comment 11

[Oleg Romashin (:romaxa)]

Comment on attachment 437951 [details] [diff] [review]
Snap to pixels by default

Not sure, but probably we should remove layout/base/nsPresShell.cpp changes in this case...

Comment 12

[Oleg Romashin (:romaxa)]

Attachment: version after discussion

Comment 13

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Hmm, is PixelSnappedRectangleAndSetPattern actually correct here? I think we need to do something to set up scaling of the pattern correctly.

Comment 14

[Robert O'Callahan (:roc) (email my personal email if necessary)]

I will probably fix this in bug 602200

Comment 15

[BugBot [:suhaib / :marco/ :calixte]]

The bug assignee didn't login in Bugzilla in the last 7 months.
:bhood, could you have a look please?
For more information, please visit auto_nag documentation.