Closed Bug 558108 Opened 14 years ago Closed 14 years ago

Reduce fuzzy page-fit-zoom threshold and make it a pref

Categories

(Firefox for Android Graveyard :: Panning/Zooming, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: mbrubeck, Assigned: mbrubeck)

Details

Attachments

(1 file)

Attached patch patchSplinter Review
For bug 454456 we added a threshold of 0.2 to page zoom.  That is, we use the "page zoom" level only if the difference from 1.0 is more than 0.2.

After some use, this seems too big - it cuts off large portions of some pages, and leaves large blank areas on others.  This patch reduces the threshold from 0.2 to 0.1, and makes it configurable for further experimentation.

Because prefs can't be floating-point, the new pref is actually the inverse of the old constant.
Attachment #437887 - Flags: review?(mark.finkle)
Assignee: nobody → mbrubeck
Status: NEW → ASSIGNED
Attachment #437887 - Flags: review?(mark.finkle) → review+
pushed:
http://hg.mozilla.org/mobile-browser/rev/72bf95a744ee
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Hm, I'm seeing a lot of checkerboards when zooming out with this patch on various sites like mobile support and sqaforums.com using the n900 as well as the n810. Would this patch have something to do with that?
No, this shouldn't affect whether checkerboards are displayed.  (In my own quick test, I am seeing equal checkerboards on sqaforums.com with and without the patch.)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: