558163 - jemalloc warning C4273: '_expand/_msize/_recalloc' : inconsistent dll linkage

Status: RESOLVED WONTFIX

(Core :: Memory Allocator, defect)

Description

[Serge Gautherie (:sgautherie)]

http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1270750090.1270757186.29337.gz&fulltext=1
WINNT 5.2 mozilla-central build on 2010/04/08 11:08:10
{
nsMemoryReporterManager.cpp
e:\builds\moz2_slave\mozilla-central-win32\build\obj-firefox\dist\include\jemalloc.h(84) : warning C4273: 'moz_malloc' : inconsistent dll linkage
        e:\builds\moz2_slave\mozilla-central-win32\build\obj-firefox\dist\include\mozilla/mozalloc.h(127) : see previous definition of 'moz_malloc'
e:\builds\moz2_slave\mozilla-central-win32\build\obj-firefox\dist\include\jemalloc.h(86) : warning C4273: 'moz_calloc' : inconsistent dll linkage
        e:\builds\moz2_slave\mozilla-central-win32\build\obj-firefox\dist\include\mozilla/mozalloc.h(134) : see previous definition of 'moz_calloc'
e:\builds\moz2_slave\mozilla-central-win32\build\obj-firefox\dist\include\jemalloc.h(87) : warning C4273: 'moz_realloc' : inconsistent dll linkage
        e:\builds\moz2_slave\mozilla-central-win32\build\obj-firefox\dist\include\mozilla/mozalloc.h(141) : see previous definition of 'moz_realloc'
e:\builds\moz2_slave\mozilla-central-win32\build\obj-firefox\dist\include\jemalloc.h(88) : warning C4273: 'moz_free' : inconsistent dll linkage
        e:\builds\moz2_slave\mozilla-central-win32\build\obj-firefox\dist\include\mozilla/mozalloc.h(121) : see previous definition of 'moz_free'
}

I don't know if they were there before or appeared after bug 550401 push.

Comment 1

[Chris Peterson [:cpeterson]]

I now see different warnings about inconsistent dll linkage from jemalloc functions:

> memory/mozjemalloc/jemalloc.c(6821) : warning C4273: '_recalloc' : inconsistent dll linkage
> memory/mozjemalloc/jemalloc.c(6848) : warning C4273: '_expand' : inconsistent dll linkage
> memory/mozjemalloc/jemalloc.c(6857) : warning C4273: '_msize' : inconsistent dll linkage

Comment 2

[Chris Peterson [:cpeterson]]

https://tbpl.mozilla.org/php/getParsedLog.php?id=42816626&tree=Mozilla-Central&full=1

c:/builds/moz2_slave/m-cen-w32-d-000000000000000000/build/memory/mozjemalloc/jemalloc.c(6821) : warning C4273: '_recalloc' : inconsistent dll linkage
c:\PROGRA~2\MICROS~2.0\vc\include\stdlib.h(604) : see previous definition of '_recalloc'

c:/builds/moz2_slave/m-cen-w32-d-000000000000000000/build/memory/mozjemalloc/jemalloc.c(6848) : warning C4273: '_expand' : inconsistent dll linkage
c:\PROGRA~2\MICROS~2.0\vc\include\malloc.h(157) : see previous definition of '_expand'

c:/builds/moz2_slave/m-cen-w32-d-000000000000000000/build/memory/mozjemalloc/jemalloc.c(6857) : warning C4273: '_msize' : inconsistent dll linkage
c:\PROGRA~2\MICROS~2.0\vc\include\malloc.h(158) : see previous definition of '_msize'

Comment 3

[Mike Hommey [:glandium]]

The warnings have been "masked" in bug 1226907, and I don't think there's actually anything actionable in this bug. We're getting definitions from stdlib that are meant to be used with dllimport, and are defining the symbols as dllexport on purpose because we do want to export them, so those warnings are bound to stick, and there's not much we can do, short of putting them in a different source file that doesn't include stdlib.h...

Wontfix?

Comment 4

[Chris Peterson [:cpeterson]]

SGTM