Closed
Bug 558202
Opened 14 years ago
Closed 14 years ago
enter/escape keys don't work correctly in confirmEx in Fennec
Categories
(Firefox for Android Graveyard :: General, defect)
Firefox for Android Graveyard
General
Tracking
(Not tracked)
VERIFIED
FIXED
People
(Reporter: mbrubeck, Assigned: mbrubeck)
Details
Attachments
(1 file)
|
2.26 KB,
patch
|
mfinkle
:
review+
|
Details | Diff | Splinter Review |
Pressing "return" or "escape" in a confirmEx prompt returns a result of "true" or "false" instead of the expected button index. Furthermore, the default button for confirmEx is most often button 0 and the cancel button is most often button 1, so the keys end up with the opposite meaning. For example, in the "Close all tabs?" prompt, pressing escape causes Fennec to close, while pressing "enter" cancels the action. The attached patch makes confirmEx behave as it does in desktop Firefox.
Attachment #437990 -
Flags: review?(mark.finkle)
|
||
Updated•14 years ago
|
Attachment #437990 -
Flags: review?(mark.finkle) → review+
|
|
||
Comment 1•14 years ago
|
||
Good find and fix! pushed: http://hg.mozilla.org/mobile-browser/rev/27222cffa39d
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
|
||
Comment 2•14 years ago
|
||
verified FIXED On build: Mozilla/5.0 (X11; U; Linux armv7l; Nokia N900; en-US; rv:1.9.2.4pre) Gecko/20100412 Namoroka/3.6.4pre Fennec/1.1a2pre
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•