Switch contributions "What's this?" dropdown to the install button style

VERIFIED FIXED in 5.12

Status

addons.mozilla.org Graveyard
Code Quality
P3
normal
VERIFIED FIXED
8 years ago
2 years ago

People

(Reporter: jbalogh, Assigned: potch)

Tracking

Dependency tree / graph

Details

(Whiteboard: [z][qa!])

(Reporter)

Description

8 years ago
The button's popup styling is all hanging off of .install-note.  We should give that a better name and use it everywhere we have a dropdown.  Feel free to expand the scope of this bug to any other ugly dropdowns you can find. :)
(Reporter)

Updated

8 years ago
Target Milestone: 5.10 → 5.11
Potch, can you take a look? The install-note dropdowns are somewhat tricky to reposition in an arbitrary spot on screen :-/
Assignee: fwenzel → thepotch
Target Milestone: 5.11 → 5.12
(Assignee)

Comment 2

7 years ago
http://github.com/jbalogh/zamboni/commit/0799c7121a1e

This commit touches the following components:

* all collection widgets (favorite, follow, add to collection, share)
* contribute "what's this" popups
* review flagging popup
* collection "change owner" interaction

touching the following pages

collection/addon detail and listing pages
addon review pages
collection edit contributors
Status: NEW → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
w00t
(Reporter)

Comment 4

7 years ago
[qa!] since this touches a bunch of pages.  QA: it's all frontend stuff.
Whiteboard: [z] → [z][qa!]

Updated

7 years ago
Depends on: 598067

Updated

7 years ago
Depends on: 599109

Comment 5

7 years ago
verified in all the places mentioned in comment 2
Status: RESOLVED → VERIFIED
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.