Closed Bug 558219 Opened 15 years ago Closed 15 years ago

Update filter.py to return "report" for lorentz strings.

Categories

(Firefox Build System :: General, defect)

Product:
Firefox Build System
Component:
General
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(blocking1.9.2 .4+, status1.9.2 .4-fixed)

Status:
RESOLVED FIXED
Tracking Flags:
Tracking Status
blocking1.9.2 --- .4+
status1.9.2 --- .4-fixed

People

(Reporter: Pike, Assigned: Pike)

References

Details

(Whiteboard: [qa-noaction-192])

Attachments

(1 file)

add toolkit/locales/filter.py and make lorentz strings "report"-only
2.86 KB, patch
bhearsum
: feedback+
beltzner
: approval1.9.2.4+
Details | Diff | Splinter Review
In bug 555178, we're adding support to compare-locales to be a bit more clever in terms of handling lorentz-like strings. Instead of plain fail or pass, we're moving to triple state, "error", "report", or "ignore". Once that's in production, we should update releases/mozilla-1.9.2/browser/locales/filter.py, and split off parts to releases/mozilla-1.9.2/toolkit/locales/filter.py, so that we can actually safely release 3.6.4. I'll come up with a patch tomorrow.
Depends on: 555178
Marking as blocking .4
blocking1.9.2: ? → .4+
As bhearsum is running a test on the upcoming 1.9.2 release, I'll put a feedback request on him. If the testrun works out fine, I'll move in on landing this patch.
Attachment #438116 - Flags: feedback?(bhearsum)
Coop, this is the accompanying patch to filter.py for the compare-locales landing that we talked about.
Comment on attachment 438116 [details] [diff] [review] add toolkit/locales/filter.py and make lorentz strings "report"-only Worked fine in my staging run.
Attachment #438116 - Flags: feedback?(bhearsum) → feedback+
Comment on attachment 438116 [details] [diff] [review] add toolkit/locales/filter.py and make lorentz strings "report"-only Requesting approval for 1.9.2 landing.
Attachment #438116 - Flags: approval1.9.2.4?
Comment on attachment 438116 [details] [diff] [review] add toolkit/locales/filter.py and make lorentz strings "report"-only a1924=beltzner
Attachment #438116 - Flags: approval1.9.2.4? → approval1.9.2.4+
Comment on attachment 438116 [details] [diff] [review] add toolkit/locales/filter.py and make lorentz strings "report"-only Actually, this patch didn't work on Windows: (view as text) python ../../../compare-locales/scripts/compare-locales l10n.ini ../../../users/stage-ffxbld bn-BD in dir e:\builds\moz2_slave\win32_repack\build/mozilla-1.9.2/browser/locales (timeout 1200 secs) watching logfiles {} argv: ['python', '../../../compare-locales/scripts/compare-locales', 'l10n.ini', '../../../users/stage-ffxbld', 'bn-BD'] environment: !::=::\ !EXITCODE=00000001 ALLUSERSPROFILE=C:\Documents and Settings\All Users APPDATA=C:\Documents and Settings\cltbld\Application Data APR_ICONV_PATH=d:/mozilla-build/svn-win32-1.6.3/iconv BOOTMODE=BKSTD BUILDSLAVE_PASSWORD="secret" BUILDSLAVE_TACFILE="e:\builds\moz2_slave\buildbot.tac" CLUSTERLOG=C:\WINDOWS\Cluster\cluster.log COLORFGBG=0;default;15 COLORTERM=rxvt-xpm COMMONPROGRAMFILES=C:\Program Files\Common Files COMPUTERNAME=WIN32-SLAVE21 COMSPEC=C:\WINDOWS\system32\cmd.exe CONTROLFILE="e:\buildbot-tac.control" CVS_RSH=ssh DEVENVDIR=d:\msvs8\Common7\IDE DISPLAY=:0 EDITOR=emacs.exe --no-window-system FP_NO_HOST_CHECK=NO FRAMEWORKDIR=C:\WINDOWS\Microsoft.NET\Framework FRAMEWORKSDKDIR=d:\msvs8\SDK\v2.0 FRAMEWORKVERSION=v2.0.50727 HOME=c:/Documents and Settings/cltbld HOMEDRIVE=C: HOMEPATH=\ HOSTNAME=win32-slave21 HOSTTYPE=i686 INCLUDE=d:\sdks\v7.0\\include;d:\sdks\v7.0\\include\atl;d:\msvs8\VC\ATLMFC\INCLUDE;d:\msvs8\VC\INCLUDE;d:\msvs8\VC\PlatformSDK\include; INPUTRC=D:/mozilla-build/msys/etc/inputrc LIB=d:\sdks\v7.0\\lib;d:\msvs8\VC\ATLMFC\LIB;d:\msvs8\VC\LIB;d:\msvs8\VC\PlatformSDK\lib;d:\msvs8\SDK\v2.0\lib;;D:\mozilla-build\\atlthunk_compat LIBPATH=C:\WINDOWS\Microsoft.NET\Framework\v2.0.50727;d:\msvs8\VC\ATLMFC\LIB LOGNAME=cltbld LOGONSERVER=\\WIN32-SLAVE21 MACHTYPE=i686-pc-msys MAKE_MODE=unix MOZILLABUILD=D:\mozilla-build\ MOZILLABUILDDRIVE=D: MOZILLABUILDPATH=\mozilla-build\ MOZ_MSVCVERSION=8 MOZ_NO_RESET_PATH=1 MOZ_TOOLS=D:\mozilla-build\\moztools MSVC6KEY=HKLM\SOFTWARE\Microsoft\VisualStudio\6.0\Setup\Microsoft Visual C++ MSVC71KEY=HKLM\SOFTWARE\Microsoft\VisualStudio\7.1\Setup\VC MSVC8EXPRESSKEY=HKLM\SOFTWARE\Microsoft\VCExpress\8.0\Setup\VC MSVC8KEY=HKLM\SOFTWARE\Microsoft\VisualStudio\8.0\Setup\VC MSVC9EXPRESSKEY=HKLM\SOFTWARE\Microsoft\VCExpress\9.0\Setup\VC MSVC9KEY=HKLM\SOFTWARE\Microsoft\VisualStudio\9.0\Setup\VC MSVCEXPROOTKEY=HKLM\SOFTWARE\Microsoft\VCExpress MSVCROOTKEY=HKLM\SOFTWARE\Microsoft\VisualStudio MSYSTEM=MINGW32 NUMBER_OF_PROCESSORS=1 NVAPSDK=D:\sdks\tegra042\ OLDPWD=d:/mozilla-build OS=Windows_NT OSTYPE=msys PASSWORD="secret" PATH=D:\mozilla-build\msys\local\bin;d:\mozilla-build\wget;d:\mozilla-build\7zip;d:\mozilla-build\blat261\full;d:\mozilla-build\python25;d:\mozilla-build\svn-win32-1.6.3\bin;d:\mozilla-build\upx203w;d:\mozilla-build\emacs-22.3\bin;d:\mozilla-build\info-zip;d:\mozilla-build\nsis-2.22;d:\mozilla-build\nsis-2.33u;d:\mozilla-build\hg;d:\mozilla-build\python25\Scripts;d:\mozilla-build\kdiff3;d:\mozilla-build\vim\vim72;.;D:\mozilla-build\msys\local\bin;D:\mozilla-build\msys\mingw\bin;D:\mozilla-build\msys\bin;d:\sdks\v7.0\bin;d:\msvs8\Common7\IDE;d:\msvs8\VC\BIN;d:\msvs8\Common7\Tools;d:\msvs8\Common7\Tools\bin;d:\msvs8\VC\PlatformSDK\bin;d:\msvs8\SDK\v2.0\bin;c:\WINDOWS\Microsoft.NET\Framework\v2.0.50727;d:\msvs8\VC\VCPackages;c:\WINDOWS\system32;c:\WINDOWS;c:\WINDOWS\System32\Wbem;d:\mozilla-build\python25;d:\mercurial;c:\Program Files\Microsoft SQL Server\90\Tools\binn\;d:\sdks\tegra042\tools;d:\sdks\tegra042\platformlibs\bin\winxp\x86\release;d:\sdks\tegra042\3rdparty\bin\winxp\x86\release;d:\mozilla-build\moztools\bin PATHEXT=.COM;.EXE;.BAT;.CMD;.VBS;.VBE;.JS;.JSE;.WSF;.WSH PROCESSOR_ARCHITECTURE=x86 PROCESSOR_IDENTIFIER=x86 Family 6 Model 15 Stepping 8, GenuineIntel PROCESSOR_LEVEL=6 PROCESSOR_REVISION=0f08 PROGRAMFILES=C:\Program Files PROMPT=$P$G PS1=\[\033]0;$MSYSTEM:\w\007 \033[32m\]\u@\h \[\033[33m\w\033[0m\] $ PWD=c:/Documents and Settings/cltbld PYTHONPATH=../../../compare-locales/lib SDK2003SP1KEY=HKLM\SOFTWARE\Microsoft\MicrosoftSDK\InstalledSDKs\8F9E5EF3-A9A5-491B-A889-C58EFFECE8B3 SDK2003SP2KEY=HKLM\SOFTWARE\Microsoft\MicrosoftSDK\InstalledSDKs\D2FF9F89-8AA2-4373-8A31-C838BF4DBBE1 SDK61KEY=HKLM\SOFTWARE\Microsoft\Microsoft SDKs\Windows\v6.1 SDK6AKEY=HKLM\SOFTWARE\Microsoft\Microsoft SDKs\Windows\v6.0A SDK6KEY=HKLM\SOFTWARE\Microsoft\Microsoft SDKs\Windows\v6.0 SDK7KEY=HKLM\SOFTWARE\Microsoft\Microsoft SDKs\Windows\v7.0 SDKDIR=d:\sdks\v7.0\ SDKMINORVER=0 SDKROOTKEY=HKLM\SOFTWARE\Microsoft\MicrosoftSDK\InstalledSDKs SDKVER=7 SESSIONNAME=Console SHELL=D:/mozilla-build/msys/bin/sh SHLVL=1 SSH_AGENT_PID=2564 SSH_AUTH_SOCK=C:/DOCUME~1/cltbld/LOCALS~1/Temp/ssh-tcssDf2512/agent.2512 SYSTEMDRIVE=C: SYSTEMROOT=C:\WINDOWS TACSCRIPT="d:\tools\buildbot-helpers\buildbot-tac.py" TEMP=C:/DOCUME~1/cltbld/LOCALS~1/Temp TEMPVC9DIR=d:\msvs9\VC\ TERM=msys TMP=C:/DOCUME~1/cltbld/LOCALS~1/Temp TRY_PASSWORD="secret" USERDOMAIN=WIN32-SLAVE21 USERNAME=cltbld USERPROFILE=C:\Documents and Settings\cltbld USESDK=1 VC8DIR=d:\msvs8\VC\ VC9DIR=d:\msvs9\VC\ VCINSTALLDIR=d:\msvs8\VC VS80COMNTOOLS=d:\msvs8\Common7\Tools\ VS90COMNTOOLS=d:\msvs9\Common7\Tools\ VSINSTALLDIR=d:\msvs8 WIN64=0 WINCURVERKEY=HKLM\SOFTWARE\Microsoft\Windows\CurrentVersion WINDIR=C:\WINDOWS WINDOWID=167851080 _=d:/mozilla-build/python25/scripts/buildbot closing stdin using PTY: False bn-BD browser chrome/browser browser.properties +crashedpluginsMessage.learnMore +crashedpluginsMessage.reloadButton.accesskey +crashedpluginsMessage.reloadButton.label +crashedpluginsMessage.submitButton.accesskey +crashedpluginsMessage.submitButton.label +crashedpluginsMessage.title preferences/advanced.dtd +submitCrashes.accesskey +submitCrashes.label searchplugins amazondotcom.xml // add and localize this file answers.xml // add and localize this file cellbazaar.xml // remove this file clickbd.xml // remove this file creativecommons.xml // add and localize this file eBay.xml // add and localize this file google.xml // add and localize this file wikipedia-bn.xml // remove this file wikipedia.xml // add and localize this file yahoo.xml // add and localize this file toolkit/chrome/mozapps/plugins/plugins.dtd +reloadPlugin.middle +reloadPlugin.post +reloadPlugin.pre +report.disabled +report.failed +report.please +report.submitted +report.submitting +report.unavailable bn-BD: keys: 940 unchanged: 394 changed: 4801 missing: 17 92% of entries changed program finished with exit code 1 elapsedTime=3.172000
I reopened bug 555178, I'm pretty sure that filter.py isn't found at all on Windows.
bhearsum confirmed that it was bug 555178, pushed the changes to filter.py's to 1.9.2, http://hg.mozilla.org/releases/mozilla-1.9.2/rev/ad815619652f.
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
status1.9.2: --- → .4-fixed
Nothing for QA to do here with this bug for verification.
Whiteboard: [qa-noaction-192]
Component: Build Config → General
Product: Firefox → Firefox Build System
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: