Able to Reset Sync during Private Browsing mode

RESOLVED FIXED

Status

Cloud Services
Firefox Sync: UI
RESOLVED FIXED
8 years ago
8 years ago

People

(Reporter: tchung, Assigned: mconnor)

Tracking

unspecified
Points:
---
Bug Flags:
blocking-weave1.2 +

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [weave1.2b5])

Attachments

(4 attachments, 1 obsolete attachment)

(Reporter)

Description

8 years ago
Created attachment 438041 [details]
Reset Sync screenshot 1

The reset sync option still works in private browsing mode, and will delete all your entries, despite indicating its disabled. 

See screenshots and logfile.

Repro:
1) install weave 1.2b5
2) log into your weave account
3) enter private browsing mode
4) notice it says weave disabled
5) click Weave > Preferences
6) when weave prefpane opens, click Manage Account > Reset sync
7) replace all data option
8) verify it deletes all your bookmarks, but unable to sync all your existing bookmarks.  Should never have reached this step in the first place due to private browsing

Expected:
- Reset Sync features should be disabled in private browsing 

Actual:
- reset sync works, and never recovers my data
(Reporter)

Comment 1

8 years ago
nom blocking-1.2?
Severity: normal → major
Flags: blocking-weave1.3?
Flags: blocking-weave1.2?
Whiteboard: [weave1.2b5]
(Reporter)

Comment 2

8 years ago
Created attachment 438042 [details]
Reset Sync screenshot 2
(Reporter)

Comment 3

8 years ago
Created attachment 438043 [details]
activity log file
(Reporter)

Comment 4

8 years ago
i'll add that after existing private browsing in this horked mode already, my normal browsing also all my missing bookmarks and history.
(Assignee)

Comment 5

8 years ago
Changes made in private browsing (i.e. to bookmarks, prefs, etc) do persist, so that's expected, at least.  bug 551572 will prevent this case (wipe before we check for PB) already, but we should just disable the manage account expander when PB is active.
(Assignee)

Comment 6

8 years ago
Created attachment 438069 [details] [diff] [review]
v1

* disable expander, collapse if expanded
Assignee: nobody → mconnor
Status: NEW → ASSIGNED
Attachment #438069 - Flags: review?(edilee)
(Assignee)

Comment 7

8 years ago
As a note, this was not as much of an issue before 1.2 because you could only Start Over, and the login fields would be disabled.  Short=circuiting that could lead to this bad UX.

As a note, there is no unexpected dataloss here, the user has explicitly chosen to nuke local data, we just fail to retrieve server data until the first post-PB sync.  It's a pretty bad/confusing user experience though, so we'll fix this for 1.2 (and harden the API against this in 1.3).
Whiteboard: [weave1.2b5] → [weave1.2b5][has patch][needs review Mardak]
(Assignee)

Comment 8

8 years ago
Created attachment 438071 [details] [diff] [review]
v1.1

this is belt and suspenders already, but hey, why not add an extra belt!

* if we're in the middle of resetting sync, clear that state and update the prefpane.
Attachment #438069 - Attachment is obsolete: true
Attachment #438071 - Flags: review?(edilee)
Attachment #438069 - Flags: review?(edilee)
(Assignee)

Updated

8 years ago
Flags: blocking-weave1.3?
Flags: blocking-weave1.2?
Flags: blocking-weave1.2+

Updated

8 years ago
Attachment #438071 - Flags: review?(edilee) → review+

Updated

8 years ago
Whiteboard: [weave1.2b5][has patch][needs review Mardak] → [weave1.2b5][has patch][has review]
(Assignee)

Comment 9

8 years ago
http://hg.mozilla.org/labs/weave/rev/9d75fd9ae6df
Able to Reset Sync during Private Browsing mode, r=Mardak
Severity: major → normal
Status: ASSIGNED → RESOLVED
Last Resolved: 8 years ago
Component: Sync → Firefox UI
OS: Mac OS X → All
QA Contact: sync → firefox
Hardware: x86 → All
Resolution: --- → FIXED
Summary: Able to Reset Sync during Private Browsing mode and deletes all data → Able to Reset Sync during Private Browsing mode
Whiteboard: [weave1.2b5][has patch][has review] → [weave1.2b5]
You need to log in before you can comment on or make changes to this bug.