558268 - Able to Reset Sync during Private Browsing mode

Status: RESOLVED FIXED

(Firefox :: Sync, defect)

Description

[Tony Chung [:tchung]]

Attachment: Reset Sync screenshot 1

The reset sync option still works in private browsing mode, and will delete all your entries, despite indicating its disabled. 

See screenshots and logfile.

Repro:
1) install weave 1.2b5
2) log into your weave account
3) enter private browsing mode
4) notice it says weave disabled
5) click Weave > Preferences
6) when weave prefpane opens, click Manage Account > Reset sync
7) replace all data option
8) verify it deletes all your bookmarks, but unable to sync all your existing bookmarks.  Should never have reached this step in the first place due to private browsing

Expected:
- Reset Sync features should be disabled in private browsing 

Actual:
- reset sync works, and never recovers my data

Comment 1

[Tony Chung [:tchung]]

nom blocking-1.2?

Comment 2

[Tony Chung [:tchung]]

Attachment: Reset Sync screenshot 2

Comment 3

[Tony Chung [:tchung]]

Attachment: activity log file

Comment 4

[Tony Chung [:tchung]]

i'll add that after existing private browsing in this horked mode already, my normal browsing also all my missing bookmarks and history.

Comment 5

[Mike Connor [:mconnor]]

Changes made in private browsing (i.e. to bookmarks, prefs, etc) do persist, so that's expected, at least.  bug 551572 will prevent this case (wipe before we check for PB) already, but we should just disable the manage account expander when PB is active.

Comment 6

[Mike Connor [:mconnor]]

Attachment: v1

* disable expander, collapse if expanded

Comment 7

[Mike Connor [:mconnor]]

As a note, this was not as much of an issue before 1.2 because you could only Start Over, and the login fields would be disabled.  Short=circuiting that could lead to this bad UX.

As a note, there is no unexpected dataloss here, the user has explicitly chosen to nuke local data, we just fail to retrieve server data until the first post-PB sync.  It's a pretty bad/confusing user experience though, so we'll fix this for 1.2 (and harden the API against this in 1.3).

Comment 8

[Mike Connor [:mconnor]]

Attachment: v1.1

this is belt and suspenders already, but hey, why not add an extra belt!

* if we're in the middle of resetting sync, clear that state and update the prefpane.

Comment 9

[Mike Connor [:mconnor]]

http://hg.mozilla.org/labs/weave/rev/9d75fd9ae6df
Able to Reset Sync during Private Browsing mode, r=Mardak