558384 - testconfig include directive should take precedence over a skip directive

Status: VERIFIED FIXED

(Tamarin Graveyard :: Tools, defect)

Description

[Chris Peyer]

If a test is 'skip'ed globally (.*) and then included for a specific configuration, the test is still skipped for the included config.

Comment 1

[Chris Peyer]

Attachment: Ignore skip command if the test/testcase has been explicitly included

Make include override any skip command defined for the same configuration:

even if a test is skipped and included for the exact same config string, include takes precedence - testconfig sample:

misc/catchableTimeout, .*deep, skip, skip slow tests
misc/catchableTimeout, .*deep, include, include slow tests in deep phase

given the above, catchableTimeout will still run in deep configurations

Comment 2

[Chris Peyer]

Just to clarify - the typical setup for deep tests in testconfig would be:

misc/catchableTimeout, .*, skip, skip slow tests
misc/catchableTimeout, .*deep, include, include slow tests in deep phase

The example in comment #1 was to demonstrate that include will override skip no matter what.

Comment 3

[Chris Peyer]

pushed to tr and argo:
changeset 4374	657134ccf268