558393 - Separate implementation of special frame properties from other properties in nsWindowSH

Status: NEW

(Core :: DOM: Core & HTML, defect, P5)

Description

[Jason Orendorff [:jorendorff]]

nsWindowSH::NewResolve currently defines a property like so:

For a numbered element, window[0] or equivalently frames[0]:

6282        *_retval = ::JS_DefineElement(cx, obj, JSVAL_TO_INT(id), JSVAL_VOID,
6283                                      nsnull, nsnull, 0);

For a string, window.framename or frames.framename or frames["framename"]:

6430        PRBool ok = ::JS_DefineUCProperty(cx, obj, chars,
6431                                          ::JS_GetStringLength(str),
6432                                          v, nsnull, nsnull, 0);

nsWindowSH::GetProperty then has a special case for each of the above.

I propose we factor those special cases into separate getters and Define with an appropriate getter and setter.

Comment 1

[Firefox Bug Husbandry Bot]

https://bugzilla.mozilla.org/show_bug.cgi?id=1472046

Move all DOM bugs that haven't been updated in more than 3 years and has no one currently assigned to P5.

If you have questions, please contact :mdaly.