558434 - Winless, transparent, silverlight doesn't display correctly

Status: VERIFIED FIXED

(Core Graveyard :: Plug-ins, defect)

Description

[Jim Mathies [:jimm]]

Attachment: comparison

noticed this today while doing some testing.

Comment 1

[Jim Mathies [:jimm]]

(In reply to comment #0)
> Created an attachment (id=438159) [details]
> comparison
> 
> noticed this today while doing some testing.

Note in that comparison shot, the upper image shows a "black background" in the page w/silverlight, which should be transparent. The lower image with the white background is the preview. This bug is related to flash bug 552062.

Comment 2

[Jim Mathies [:jimm]]

This isn't an OOPP problem, I can reproduce this on trunk with oopp/disabled.

Comment 3

[Jim Mathies [:jimm]]

Attachment: screen cap

Comment 4

[Jim Mathies [:jimm]]

(In reply to comment #2)
> This isn't an OOPP problem, I can reproduce this on trunk with oopp/disabled.

I can also reproduce it on 3.6.4pre.

Comment 5

[Benjamin Smedberg]

What about 3.6.3? Regressions are a big deal, pre-existing bugs aren't so much.

Comment 6

[Jim Mathies [:jimm]]

(In reply to comment #5)
> What about 3.6.3? Regressions are a big deal, pre-existing bugs aren't so much.

It's a regression in 3.6.4, 3.6.3 doesn't exhibit the problem.

Comment 7

[Jim Mathies [:jimm]]

One unrelated thing I noticed while testing, I had "dom.ipc.plugins.enabled" set to false, with "dom.ipc.plugins.enabled.npctrl.dll" defaulted to true. The plugin container process for silverlight still launched. I had to disable "dom.ipc.plugins.enabled.npctrl.dll" before I was able to confirm this wasn't OOPP. Is that a bug in our prefs benjamin?

Comment 8

[Jim Mathies [:jimm]]

http://hg.mozilla.org/projects/firefox-lorentz/pushloghtml?startdate=2010-03-18&enddate=2010-03-23

Doesn't help much, but here's a regression range (3-18 -> 3-23) for the Lorentz nightlies.

Comment 9

[Jim Mathies [:jimm]]

Found it! Changes we made to nsObjectFrame::IsOpaque caused this. Silverlight doesn't set the transparent property to true in this case. Technically probably a bug in silverlight, but since older versions of fx didn't care, I suppose it partially our fault. Here are the changes:

http://hg.mozilla.org/releases/mozilla-1.9.2/rev/32a2e349d7cf

Either we back those changes out, or we quirk GetValue(nsPluginInstanceVariable_TransparentBool) to always return PR_TRUE for windowless silverlight version <= 3.0.

Comment 10

[Jim Mathies [:jimm]]

Attachment: fix

Comment 11

[Brandon Sterne (:bsterne)]

Code freeze for 1.9.2.4 is midnight tonight.  Not blocking but if you can finish the review by then, we'd be happy to take this fix.

Comment 12

[Jim Mathies [:jimm]]

cc'ing Ashish @ MS. Ashish, in previous version of fx, we assumed windowless controls were transparent. In the next update, we've removed that assumption. It looks like silverlight relied on this. Silverlight should be calling set value for transparency, but doesn't appear to be doing so. We've fixed this by making the transparent property default true for silverlight windowless controls. To work around this, silverlight should always set the transparent property after setting the windowless property in future releases.

Comment 13

[Jim Mathies [:jimm]]

Attachment: updated patch

updated w/sl version info in the comment.

Comment 14

[Jim Mathies [:jimm]]

http://hg.mozilla.org/mozilla-central/rev/9614b3d45ff4

Comment 15

[LegNeato]

Comment on attachment 438552 [details] [diff] [review]
updated patch

a=LegNeato for 1.9.2.4

Comment 16

[Jim Mathies [:jimm]]

http://hg.mozilla.org/releases/mozilla-1.9.2/rev/5799b96ff387

Comment 17

[Kevin Brosnan]

Verified

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2.4) Gecko/20100611 Firefox/3.6.4

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.3a6pre) Gecko/20100619 Minefield/3.7a6pre