558480 - Account Setup dialog steals focus from reading the TOC website

Status: VERIFIED FIXED

(Firefox :: Sync, defect)

Description

[Tony Chung [:tchung]]

Attachment: weave TOC screenshot

When selecting the weave terms of condition on the new account creation dialog, the window steals focus and does not allow the user to navigate to the browser to actually view the TOC.  The only way they can do that is to cancel their registration.  

I suggest defocusing the window and allowing the user to navigate back to the TOC window after they have control again.  

See screenshot

Repro:
1) install weave 1.2b5
2) create a new weave account
3) at the new account page, click the "Terms of Service" link
4) notice the TOC appears in the browser window behind the TOC window, but the user cannot unfocus from the TOC dialog unless they proceed with action.  This is useless if the user cannot view the TOC before the accept it.

Expected:
- new user account dialog should not have a locked focus, and thus allow the user to view the TOC

Actual:
- unable to get to TOC page without cancelling or next dialog

Comment 1

[Mike Connor [:mconnor]]

I hate modal prefwindows so much.

Comment 2

[Mike Connor [:mconnor]]

Probably also true for the reset password link.

Comment 3

[Mike Connor [:mconnor]]

Attachment: v1

This gets moved and cleaned up better in bug 562183, but this is the specific fix for that bug.

Comment 4

[Mike Connor [:mconnor]]

http://hg.mozilla.org/labs/weave/rev/f1884c55a3ca

Comment 5

[Tracy Walker [:tracy]]

verified with 1.3b6